Terms of service must be accepted when using OAuth to register #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
approved these changes
Mar 12, 2023
frontend/src/locales/de.json
Outdated
| @@ -366,6 +366,7 @@ | |||
| "title": "Dein Account wird aktiviert" | |||
| }, | |||
| "login": { | |||
| "acceptTermsOfUseOnOAuthLogin": "Beim Login via einen diese Services akzeptierst du die {termsOfServiceLink}.", | |||
There was a problem hiding this comment.
Suggested change
| "acceptTermsOfUseOnOAuthLogin": "Beim Login via einen diese Services akzeptierst du die {termsOfServiceLink}.", | |
| "acceptTermsOfServiceOnOAuthLogin": "Beim Login via einen diese Services akzeptierst du die {termsOfServiceLink}.", |
TermsOfService to be consistent?
There was a problem hiding this comment.
I had taken this term over it from the Register component. So to be really consistent, I also adjusted it there.
manuelmeister
approved these changes
Mar 14, 2023
pmattmann
reviewed
Mar 14, 2023
frontend/src/locales/en.json
Outdated
| }, | ||
| "register": { | ||
| "acceptTermsOfUse": "Accept the terms of use", | ||
| "acceptTermsOfService": "Accept the terms of use", |
There was a problem hiding this comment.
Hier ist noch der einzige Ort wo terms of use steht.
Sonst immer terms of service. Ist das Absicht?
There was a problem hiding this comment.
Nope, will change, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3198
TOS pages in french and italian are not set up at the moment. To be decided: Do we set them up to redirect to english? Do we hardcode in ecamp3 which languages have no TOS translation?
Also to be decided: I have worded the notice such that it only applies to OAuth login. Do we want this to apply to "normal" logins as well? If so, is the checkbox on the register page necessary / useful at all? (I assume legally it's still better to keep the checkbox on the register page, but IANAL)