-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdf: pin @vue dependencies, that they have the same version #4062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the correct solution? Shouldn't we instead tell renovate to only update these together?
I don't think that renovate will do that for transitive dependencies. But i can try to group that, maybe it works |
I tried it here: BacLuc#217 In the pdf module we got lucky, because @vue/reactivity was already at 3.3.8. |
@@ -36,7 +36,12 @@ | |||
"@vitejs/plugin-vue": "4.4.0", | |||
"@vitest/coverage-v8": "0.34.6", | |||
"@vue/babel-preset-app": "5.0.8", | |||
"@vue/compiler-dom": "3.3.8", | |||
"@vue/compiler-sfc": "3.3.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these really be devDependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up: Write these into overrides instead of dev dependencies.
There seem to be problems on version mismatches. ecamp#4046 ecamp#3937 The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update. Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.
0a1b947
to
eb8798d
Compare
There seem to be problems on version mismatches.
#4046
#3937
The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update.
Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.
Then the update is a wonderful PR which succeeds in installing the dependencies and with a succeeding CI:
https://github.com/BacLuc/ecamp3/pull/210/files