Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf: pin @vue dependencies, that they have the same version #4062

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Nov 7, 2023

There seem to be problems on version mismatches.
#4046
#3937

The transitive dependencies seem to be updated in the lock file maintenance. The direct dependency in a normal package update.
Even in minor versions this seems to be a problem -> we pin them together, and they get updated together.

Then the update is a wonderful PR which succeeds in installing the dependencies and with a succeeding CI:
https://github.com/BacLuc/ecamp3/pull/210/files

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the correct solution? Shouldn't we instead tell renovate to only update these together?

@BacLuc
Copy link
Contributor Author

BacLuc commented Nov 8, 2023

Is this really the correct solution? Shouldn't we instead tell renovate to only update these together?

I don't think that renovate will do that for transitive dependencies.
These updates are in the lockFileMaintenance update type. I never saw that two different update types were updated in the same PR.
(the other example is minor + major, as i remember these were always separate).
It is not quite correct to list dependencies that you don't use directly,
but there is no way i know of to tell npm these packages all need the same version.

But i can try to group that, maybe it works

@BacLuc
Copy link
Contributor Author

BacLuc commented Nov 13, 2023

Is this really the correct solution? Shouldn't we instead tell renovate to only update these together?

I tried it here: BacLuc#217
with BacLuc@e9b6b0d

In the pdf module we got lucky, because @vue/reactivity was already at 3.3.8.
In print we did not get lucky, so i assume you have to pin the dependencies you want updated together,

@@ -36,7 +36,12 @@
"@vitejs/plugin-vue": "4.4.0",
"@vitest/coverage-v8": "0.34.6",
"@vue/babel-preset-app": "5.0.8",
"@vue/compiler-dom": "3.3.8",
"@vue/compiler-sfc": "3.3.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these really be devDependencies?

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: Write these into overrides instead of dev dependencies.

There seem to be problems on version mismatches.
ecamp#4046
ecamp#3937

The transitive dependencies seem to be updated in the lock file maintenance.
The direct dependency in a normal package update.
Even in minor versions this seems to be a problem ->
we pin them together, and they get updated together.
@BacLuc BacLuc force-pushed the pdf-pin-vue-dependencies-together branch from 0a1b947 to eb8798d Compare December 9, 2023 13:13
@BacLuc BacLuc added this pull request to the merge queue Dec 9, 2023
Merged via the queue into ecamp:devel with commit 4d2d157 Dec 9, 2023
28 checks passed
@BacLuc BacLuc deleted the pdf-pin-vue-dependencies-together branch December 23, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants