chore: reduce tag header by removing ManyToOne relations from tags list #7227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usu
force-pushed
the
chore/cache-improvements-many-to-one
branch
from
d4935d4 to
d4ca7e3
Compare
simfeld
approved these changes
Apr 14, 2025
BacLuc
added
the
test-flaky-e2e!
pmattmann
approved these changes
May 6, 2025
BacLuc
added
test-flaky-e2e!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on *ToMany relation tags to detect additions/removal to list (e.g. {activitiyId}#scheduleEntries listening for new scheduleEntries).
However, so far we haven't come across any usecase where we rely on a *ToOne tag.
As we have a better test coverage with various endpoints by now, I think it's safe to remove the ManyToOne tags at the moment and hence reducing the tag list significantly. Can be revisited, in case we detect any issue when implementing additional endpoints.