Add isPublic field for query performance #8274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
had a problem deploying
to
feature-branch
GitHub Actions
Error
Follow-up for ecamp#8004 Querying by isPrototype OR isShared is slow, because databases don't like OR conditions too much. We work around this by adding a combined isPublic field which is enforced to always contain isShared || isPrototype and have the DB queries filter by that.
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
carlobeltrame
force-pushed
the
shared-camps-better-performance
branch
from
25d9ca4 to
a54618b
Compare
carlobeltrame
had a problem deploying
to
feature-branch
GitHub Actions
Failure
carlobeltrame
had a problem deploying
to
feature-branch
GitHub Actions
Failure
pmattmann
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
approved these changes
Oct 4, 2025
simfeld
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #8004 after deploying that feature to staging and performing a load test using Grafana K6.
Querying by isPrototype OR isShared is slow (with our productive amount of data in the order of magnitude 100 times slower), because databases don't like OR conditions too much. We work around this by adding a combined isPublic field which is enforced to always contain isShared || isPrototype and have the DB queries filter by that.