Skip to content

Upgrade to node 14 #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Upgrade to node 14 #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a530552
Upgrade to node 14
simfeld Jan 23, 2021
32c2484
Pin node version and enable docker digest pinning
simfeld Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .docker-hub/print/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# build stage
FROM node:12.20 AS build-stage
FROM node:14.15.4 AS build-stage

COPY common /common

Expand All @@ -10,7 +10,7 @@ RUN npm ci
RUN npm run build

# production stage
FROM node:12.20 AS production-stage
FROM node:14.15.4 AS production-stage
WORKDIR /app

COPY --from=build-stage /app/node_modules ./node_modules
Expand Down
2 changes: 1 addition & 1 deletion .docker-hub/worker-print-puppeteer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12-buster-slim
FROM node:14.15.4-buster-slim

RUN apt-get update \
&& apt-get install -y wget gnupg \
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "3"

services:
frontend:
image: node:12.20
image: node:14.15.4
container_name: 'ecamp3-frontend'
ports:
- '3000:3000'
Expand Down Expand Up @@ -38,7 +38,7 @@ services:
entrypoint: ./docker-setup.sh

print:
image: node:12.20
image: node:14.15.4
container_name: 'ecamp3-print'
ports:
- '3003:3003'
Expand Down
5 changes: 3 additions & 2 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"extends": [
"config:base"
"config:base",
"docker:pinDigests"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://docs.renovatebot.com/docker/

],
"force": {
"constraints": {
"node": "= 12.20"
"node": "< 15.0.0"
}
},
"packageRules": [
Expand Down
2 changes: 1 addition & 1 deletion workers/print-puppeteer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Initially based upon:
# https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-in-docker

FROM node:12-buster-slim
FROM node:14.15.4-buster-slim

RUN apt-get update \
&& apt-get install -y wget gnupg \
Expand Down