Fix php function return types #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
force-pushed
the
fix-return-types
branch
3 times, most recently
from
6a9b5b5 to
00b2a1c
Compare
|
Können wir bitte vorher #950 mergen? |
BacLuc
reviewed
Feb 10, 2021
backend/module/eCampApi/src/eCampApi/V1/Rpc/Register/RegisterController.php
Outdated
Show resolved
Hide resolved
| 'braces' => ['position_after_functions_and_oop_constructs' => 'same'], | ||
| 'php_unit_test_class_requires_covers' => false | ||
| 'php_unit_test_class_requires_covers' => false, | ||
| 'no_superfluous_phpdoc_tags' => true, |
There was a problem hiding this comment.
will you revert the rule in this PR in a follow up commit, or do we merge it?
There was a problem hiding this comment.
This one I would merge, because it is not considered risky. If we remove it, cs-fixer will start complaining about now incomplete phpdoc annotations I think.
carlobeltrame
force-pushed
the
fix-return-types
branch
from
24fb373 to
01e6010
Compare
|
Ich habe mir noch überlegt, ob wir auch Generics definieren könnten. (Momentan nur via DocBlocks möglich) Damit wir zB bei den Services nicht immer noch einen "Cast" machen müssen. |
BacLuc
approved these changes
Feb 13, 2021
carlobeltrame
force-pushed
the
fix-return-types
branch
from
01e6010 to
9e19293
Compare
pmattmann
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838
In AuthController and Auth\BaseController, the redirect responses are necessary due to the OAuth protocol. So there, we are not able to return ViewModel. In all other places, we now return ViewModel, and also declare
voidreturn types. php-cs-fixer made this easy, but we can't permanently activate these rules without enabling risky rules.