-
Notifications
You must be signed in to change notification settings - Fork 61
Refactor Backend and Frontend for Activity-Layout #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a3a972d
rename entities, services, hydrators; create new entities
pmattmann 4c21382
services; hydrators; test-data; unittests
pmattmann a095f59
code review fixes
pmattmann b069b97
frontent activity-category -> category
pmattmann af6839f
bugfix and contentTypeConfig -> categoryContentType
pmattmann 27515d2
add unittest for activity-content-hierarchy
pmattmann c14033b
Merge remote-tracking branch 'ecamp/devel' into feature/activity-layout
pmattmann 485d6ad
fixes von review
pmattmann a432e3e
use addChild
pmattmann 7d2e552
code-review fixes
pmattmann 376899f
Merge branch 'devel' into feature/activity-layout
pmattmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/config/Rest/categoryContentType.config.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
use eCampApi\ConfigFactory; | ||
|
||
$entity = 'CategoryContentType'; | ||
$config = ConfigFactory::createConfig($entity); | ||
|
||
return $config; |
17 changes: 17 additions & 0 deletions
17
backend/module/eCampApi/config/Rest/categoryContentTypeTemplate.config.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
use eCampApi\ConfigFactory; | ||
|
||
$entity = 'CategoryContentTypeTemplate'; | ||
$config = ConfigFactory::createConfig($entity); | ||
|
||
// read-only endpoint | ||
$config['api-tools-rest']["eCampApi\\V1\\Rest\\{$entity}\\Controller"]['entity_http_methods'] = ['GET']; | ||
$config['api-tools-rest']["eCampApi\\V1\\Rest\\{$entity}\\Controller"]['collection_http_methods'] = ['GET']; | ||
|
||
array_push( | ||
$config['api-tools-rest']["eCampApi\\V1\\Rest\\{$entity}\\Controller"]['collection_query_whitelist'], | ||
'categoryTemplateId' | ||
); | ||
|
||
return $config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 0 additions & 8 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/ActivityCategory/ActivityCategoryCollection.php
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/ActivityCategory/ActivityCategoryResource.php
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
...pApi/src/eCampApi/V1/Rest/ActivityCategoryTemplate/ActivityCategoryTemplateCollection.php
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
...ampApi/src/eCampApi/V1/Rest/ActivityCategoryTemplate/ActivityCategoryTemplateResource.php
This file was deleted.
Oops, something went wrong.
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/Category/CategoryCollection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\Category; | ||
|
||
use eCamp\Lib\Entity\BaseCollection; | ||
|
||
class CategoryCollection extends BaseCollection { | ||
} |
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/Category/CategoryResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\Category; | ||
|
||
use Laminas\ApiTools\Doctrine\Server\Resource\DoctrineResource; | ||
|
||
class CategoryResource extends DoctrineResource { | ||
} |
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/CategoryContent/CategoryContentCollection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContent; | ||
|
||
use eCamp\Lib\Entity\BaseCollection; | ||
|
||
class CategoryContentCollection extends BaseCollection { | ||
} |
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/CategoryContent/CategoryContentResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContent; | ||
|
||
use Laminas\ApiTools\Doctrine\Server\Resource\DoctrineResource; | ||
|
||
class CategoryContentResource extends DoctrineResource { | ||
} |
8 changes: 8 additions & 0 deletions
8
...ampApi/src/eCampApi/V1/Rest/CategoryContentTemplate/CategoryContentTemplateCollection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContentTemplate; | ||
|
||
use eCamp\Lib\Entity\BaseCollection; | ||
|
||
class CategoryContentTemplateCollection extends BaseCollection { | ||
} |
8 changes: 8 additions & 0 deletions
8
...eCampApi/src/eCampApi/V1/Rest/CategoryContentTemplate/CategoryContentTemplateResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContentTemplate; | ||
|
||
use Laminas\ApiTools\Doctrine\Server\Resource\DoctrineResource; | ||
|
||
class CategoryContentTemplateResource extends DoctrineResource { | ||
} |
8 changes: 8 additions & 0 deletions
8
...odule/eCampApi/src/eCampApi/V1/Rest/CategoryContentType/CategoryContentTypeCollection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContentType; | ||
|
||
use eCamp\Lib\Entity\BaseCollection; | ||
|
||
class CategoryContentTypeCollection extends BaseCollection { | ||
} |
8 changes: 8 additions & 0 deletions
8
.../module/eCampApi/src/eCampApi/V1/Rest/CategoryContentType/CategoryContentTypeResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContentType; | ||
|
||
use Laminas\ApiTools\Doctrine\Server\Resource\DoctrineResource; | ||
|
||
class CategoryContentTypeResource extends DoctrineResource { | ||
} |
8 changes: 8 additions & 0 deletions
8
...rc/eCampApi/V1/Rest/CategoryContentTypeTemplate/CategoryContentTypeTemplateCollection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContentTypeTemplate; | ||
|
||
use eCamp\Lib\Entity\BaseCollection; | ||
|
||
class CategoryContentTypeTemplateCollection extends BaseCollection { | ||
} |
8 changes: 8 additions & 0 deletions
8
.../src/eCampApi/V1/Rest/CategoryContentTypeTemplate/CategoryContentTypeTemplateResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryContentTypeTemplate; | ||
|
||
use Laminas\ApiTools\Doctrine\Server\Resource\DoctrineResource; | ||
|
||
class CategoryContentTypeTemplateResource extends DoctrineResource { | ||
} |
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/CategoryTemplate/CategoryTemplateCollection.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryTemplate; | ||
|
||
use eCamp\Lib\Entity\BaseCollection; | ||
|
||
class CategoryTemplateCollection extends BaseCollection { | ||
} |
8 changes: 8 additions & 0 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/CategoryTemplate/CategoryTemplateResource.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace eCampApi\V1\Rest\CategoryTemplate; | ||
|
||
use Laminas\ApiTools\Doctrine\Server\Resource\DoctrineResource; | ||
|
||
class CategoryTemplateResource extends DoctrineResource { | ||
} |
8 changes: 0 additions & 8 deletions
8
...nd/module/eCampApi/src/eCampApi/V1/Rest/ContentTypeConfig/ContentTypeConfigCollection.php
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
backend/module/eCampApi/src/eCampApi/V1/Rest/ContentTypeConfig/ContentTypeConfigResource.php
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
...pi/src/eCampApi/V1/Rest/ContentTypeConfigTemplate/ContentTypeConfigTemplateCollection.php
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
...pApi/src/eCampApi/V1/Rest/ContentTypeConfigTemplate/ContentTypeConfigTemplateResource.php
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wären Filter oder Validierungen nötig / sinnvoll für die neuen Felder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja - siehe #827, mach ich dann mit den ConfigFactories