Fix "Cannot stringify arbitrary non-POJOs" in nuxt #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
approved these changes
May 2, 2021
There was a problem hiding this comment.
Implementation as is looks good to me. How about some unit tests?
Also, wouldn't it be possible to eventually support this kind of serialization "correctly"?
The promises can trivially be reconstructed as reloading promises or resolved promises, depending on their state during serialization (maybe even without queryablePromise, by looking at the loading flag).
The StoreValues could more or less be represented by a URI.
|
Also, maybe document this behaviour (not supporting client-side re-hydration) in the README? |
carlobeltrame
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuxt serializes Vuex store and Component data objects after the server has finished, which is then hydrated again on the client side.
This is currently not supported by hal-json-vuex. Objects would need to be refetched on client side.
In ecamp, we don't use hydration on client side, but the server still generates lots of warnings, as the serialization cannot be disabled.
This PR avoids these warnings by providing a dummy
toJSONimplementation on store promises and on StoreValue objects.Similar problem as described here: vuex-orm/vuex-orm#255