Skip to content

Conversation

usu
Copy link
Member

@usu usu commented Jan 22, 2022

Contributes to #54

Improves the error message if a primitive property or a non-existing property is used like a relation.

Previously this threw something like

t2 is not a function

@usu usu requested a review from carlobeltrame January 22, 2022 17:45
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How about a test? Should be pretty easy to write one, no?

@usu usu closed this Jan 23, 2022
@usu usu reopened this Jan 23, 2022
@usu
Copy link
Member Author

usu commented Jan 23, 2022

LGTM. How about a test? Should be pretty easy to write one, no?

Done d4e9cbd

@carlobeltrame
Copy link
Member

Thanks! Will do a release after we merge #260, okay?

@carlobeltrame carlobeltrame merged commit 515e3a7 into ecamp:next Jan 25, 2022
@usu
Copy link
Member Author

usu commented Jan 30, 2022

Thanks! Will do a release after we merge #260, okay?

Yes, good for me. Anyway nothing urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants