Skip to content
This repository has been archived by the owner on Oct 12, 2019. It is now read-only.

✨ Add personal fishing sites #46

Closed
Mortefal opened this issue Feb 21, 2019 · 2 comments
Closed

✨ Add personal fishing sites #46

Mortefal opened this issue Feb 21, 2019 · 2 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@Mortefal
Copy link
Contributor

Expected Behavior

A user should be able to create and store his own fishing spots with name and gps coordinates.

Priority

Would be nice to do this sprint.

Size

1-2

@Mortefal Mortefal added the feature New feature or request label Feb 21, 2019
@balazsorban44 balazsorban44 added this to the Sprint 2 milestone Feb 22, 2019
@balazsorban44
Copy link
Contributor

@Mortefal
Perfect place to open the dialog from:

function NoOptionsMessage(props) {
return (
<Typography
className={props.selectProps.classes.noOptionsMessage}
color="textSecondary"
{...props.innerProps}
>
{props.children}
</Typography>
)
}

This component is rendered in the Dropdown component, if no result was found. You can define an onClick method on this, that sends the user to a desired dialog.

Example:

image

So instead of saying "No option", you could say, "Add your own location", and use the onClick prop to render a dialog with some input fields

Mortefal added a commit that referenced this issue Feb 24, 2019
balazsorban44 added a commit that referenced this issue Feb 24, 2019
add children field to dialog, to be able to render custom content in dialogs #46
@Mortefal
Copy link
Contributor Author

Goes into issue #52 , however the issue is almost ready, so remains open

@balazsorban44 balazsorban44 modified the milestones: Sprint 2, Sprint 3 Feb 26, 2019
@balazsorban44 balazsorban44 changed the title ✨ New Feature Add personal fishing sites ✨ Add personal fishing sites Feb 26, 2019
@balazsorban44 balazsorban44 modified the milestones: Sprint 3, Sprint 4 Mar 11, 2019
@Mortefal Mortefal mentioned this issue Mar 16, 2019
4 tasks
balazsorban44 added a commit that referenced this issue Mar 16, 2019
balazsorban44 added a commit that referenced this issue Mar 16, 2019
balazsorban44 added a commit that referenced this issue Mar 16, 2019
balazsorban44 added a commit that referenced this issue Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants