Skip to content
This repository has been archived by the owner on Oct 12, 2019. It is now read-only.

Feature/add fishing spot #70

Merged
merged 39 commits into from
Mar 16, 2019
Merged

Feature/add fishing spot #70

merged 39 commits into from
Mar 16, 2019

Conversation

Mortefal
Copy link
Contributor

@Mortefal Mortefal commented Mar 11, 2019

Before I opened this Pull Request, I have:

  • written 📝 code documentation where it made sense
  • written tests 🔬, where it was necessary
  • updated the CHANGELOG.md file 📝
  • referenced all the issues in commits related to this PR

according to my best knowledge.

#52
closes #46

Mortefal and others added 30 commits February 23, 2019 21:05
WIP, changed names for functions in store
Not working atm, array is in option, however not shown.
Multiple bugs, one is that the "addspot" component comes in all dropdowns, solution is to make a switch case to solve it. Not sure how to implement it however.
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #70 into develop will decrease coverage by 0.88%.
The diff coverage is 16.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
- Coverage    42.36%   41.47%   -0.89%     
===========================================
  Files           50       52       +2     
  Lines          550      569      +19     
  Branches       102      104       +2     
===========================================
+ Hits           233      236       +3     
- Misses         281      297      +16     
  Partials        36       36
Impacted Files Coverage Δ
src/db/actions/messages.js 0% <ø> (ø) ⬆️
src/components/Forms/components/DropdownMap.jsx 10.81% <ø> (ø) ⬆️
src/components/shared/Dialog.jsx 80% <ø> (ø) ⬆️
src/components/Forms/FormInput.jsx 92.3% <ø> (ø) ⬆️
src/components/Forms/components/TextInput.jsx 0% <ø> (ø) ⬆️
src/db/actions/dialog.js 87.5% <ø> (ø) ⬆️
src/db/actions/customLists.js 0% <0%> (ø)
src/db/Store.js 38.46% <0%> (-3.21%) ⬇️
src/components/Forms/components/Dropdown.jsx 11.11% <12.5%> (-2.53%) ⬇️
src/components/Forms/components/GeoPointInput.jsx 12.5% <12.5%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c120af...d231dca. Read the comment docs.

@lighthousebot
Copy link
Collaborator

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 82 1
Performance 0 -
Progressive Web App 100 90
Accessibility 81 80
Best Practices 100 80

Tested with Lighthouse version: 4.2.0

@balazsorban44 balazsorban44 added the feature New feature or request label Mar 16, 2019
@balazsorban44 balazsorban44 added this to the Sprint 4 milestone Mar 16, 2019
@balazsorban44 balazsorban44 self-requested a review March 16, 2019 14:15
Copy link
Contributor

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor changes I had to make, this looks good 👌, and ready to be merged into develop, but before it can reach master, we have to bump the test coverage.

@balazsorban44 balazsorban44 merged commit 4960312 into develop Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants