This repository has been archived by the owner on Oct 12, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directly and connect to dropdown
WIP, changed names for functions in store
Not working atm, array is in option, however not shown.
Multiple bugs, one is that the "addspot" component comes in all dropdowns, solution is to make a switch case to solve it. Not sure how to implement it however.
Codecov Report
@@ Coverage Diff @@
## develop #70 +/- ##
===========================================
- Coverage 42.36% 41.47% -0.89%
===========================================
Files 50 52 +2
Lines 550 569 +19
Branches 102 104 +2
===========================================
+ Hits 233 236 +3
- Misses 281 297 +16
Partials 36 36
Continue to review full report at Codecov.
|
Updated Lighthouse report for the changes in this PR:
Tested with Lighthouse version: 4.2.0 |
balazsorban44
approved these changes
Mar 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from some minor changes I had to make, this looks good 👌, and ready to be merged into develop
, but before it can reach master
, we have to bump the test coverage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I opened this Pull Request, I have:
CHANGELOG.md
file 📝according to my best knowledge.
#52
closes #46