Skip to content

Conversation

ShubhamSPawade
Copy link
Contributor

@ShubhamSPawade ShubhamSPawade commented Oct 1, 2025

Which issue does this PR close?

Rationale for this change

The QR popup for downloading the app lacked a visible close (“×”) button and did not support overlay click-to-dismiss behavior. This could confuse users who may assume they’re stuck. The proposed changes improve usability and align with standard UX practices.

What changes are included in this PR?

  • Added a close (“×”) button in the top-right corner of the QR popup.
  • Enabled overlay click-to-dismiss functionality.
  • Prevented body scroll when the popup is active.
  • Added ESC key support to close the popup.

Are these changes tested?

Manual testing was performed to verify:

  • Clicking the close button dismisses the popup.
  • Clicking outside the popup closes it.
  • Pressing ESC key closes the popup.
  • Popup styling and transitions remain intact.

Are there any user-facing changes?

Yes. Users now have intuitive control over the QR popup.
📸 Screenshot of the updated QR popup with close button and overlay behavior.
image

Copy link

vercel bot commented Oct 1, 2025

@ShubhamSPawade is attempting to deploy a commit to the eccentriccoder01's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ShubhamSPawade ShubhamSPawade changed the title Add close button and overlay click-to-dismiss for QR popup (Issue #158) 💡 UX Enhancement : Add close button and overlay click-to-dismiss for QR popup (Issue #158) Oct 1, 2025
@ShubhamSPawade ShubhamSPawade changed the title 💡 UX Enhancement : Add close button and overlay click-to-dismiss for QR popup (Issue #158) 🎨 UX Enhancement : Add close button and overlay click-to-dismiss for QR popup (Issue #158) Oct 1, 2025
@eccentriccoder01 eccentriccoder01 added bug Something isn't working gssoc25 level 2 labels Oct 3, 2025
@eccentriccoder01
Copy link
Owner

Great work @ShubhamSPawade! Sorry for the late response, I'm merging this now... Feel free to work on more issues or create new ones, and check out my other GSSoC25 projects too:

  • TalkHeal TalkHeal
  • SaralSeva SaralSeva
  • Venturalink Venturalink
  • Spamlyser Spamlyser
     
    Thanks for improving SaralSeva 🧡

@eccentriccoder01 eccentriccoder01 merged commit 5afffa8 into eccentriccoder01:main Oct 3, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc25 level 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 UX Enhancement: Add Close Button for QR Popup
2 participants