Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect 'filename' column in batch ingest #185

Merged
merged 7 commits into from
Sep 30, 2021
Merged

Expect 'filename' column in batch ingest #185

merged 7 commits into from
Sep 30, 2021

Conversation

blms
Copy link
Contributor

@blms blms commented Sep 28, 2021

What this PR does

During batch ingest with an external metadata file:

  • Expects filename column (case-insensitive) in metadata to match a filename (case-sensitive) of a zip file
  • Generates PID using uuid4 instead of using pid column

Additional notes

  • This code sticks with UUIDs for now; this could be easily changed by modifying the generate_pid() function.
  • If a user passes in a single volume zip with a metadata file inside the zip, and it has a pid column, it will still be used as before. This PR only affects how an external metadata file associates zip filenames

@blms blms requested a review from jayvarner September 28, 2021 13:18
@blms blms marked this pull request as draft September 30, 2021 14:42
@blms blms marked this pull request as ready for review September 30, 2021 14:55
jayvarner
jayvarner approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@jayvarner jayvarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks

@jayvarner jayvarner merged commit 5f06328 into develop Sep 30, 2021
@blms blms deleted the blms/metadata-column-fix branch September 30, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvarner jayvarner jayvarner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blms @jayvarner