BugFix Patches from ScoPi #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch provided by ScoPi http://echo.nextapp.com/site/node/6713 Evidently the Extras.DropDownMenu wasn't totally fleshed out; a documented "menuWidth" property wasn't actually being applied. This change fixes that and makes the current mouseover span the width of the drop down menu. I've tested it in IE 9 and the latest Firefox. On a sidenote regarding the usage of Extras.DropDownMenu: be aware that the undocumented "selection" property of Extras.DropDownMenu refers to the index of the menu item to be selected if the "selectionEnabled" property is true and thus using that property is enabled. If the menu item model of the menu is complex, then the selection property is actually a path to the selected item in the form "firstLevelIndex.secondLevelIndex.thirdLevelIndex.andSoOn" (i.e. "3.2.5.9.13" refers to the 13th menu item in the 9th menu item in the 5th menu item in the 2nd menu item in the 3rd menu item). Note that the selection property must be forced to a string (e.g. via new String(selection)) when used or you can get some JavaScript errors since the framework tries to parse out a path like 3.2.5.9.13.
Patch provided by ScoPi http://echo.nextapp.com/site/node/6714 This changes makes it so at least the Extras.DropDownMenu renders any font applied to it; previously, it would only render the "menuFont" in the drop down menu itself. Tested in IE 9 and the latest Firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Patches from ScoPi
http://echo.nextapp.com/site/node/6714
http://echo.nextapp.com/site/node/6713
See commit notes