You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored PlausibleAnalytics component to use dataDomain and sourceDomain properties
- Updated Config interface to include sourceDomain property
- Updated plugin test cases to reflect changes in configuration properties
- Added new fields and removed old field in app-config.production.yaml under `plausible`
- Disabled the `plausible` feature in app-config.yaml for the app configuration
- Update environment variable name from PLAUSIBLE_DOMAIN to PLAUSIBLE_DATA_DOMAIN
- Add new environment variable PLAUSIBLE_SOURCE_DOMAIN
- Ensure all relevant files are updated with the new environment variable names.
3, because the PR involves multiple configuration changes across different files, including TypeScript and YAML, and also includes logic changes in a React component. Understanding the implications of these changes requires a good grasp of the project's configuration management and the Plausible analytics integration.
🧪 Relevant tests
Yes
⚡ Possible issues
Possible Bug: There is a typo in the property name soureDomain which should be sourceDomain. This could lead to runtime errors or misconfigurations because the property name does not match its usage in the code.
🔒 Security concerns
No
Code feedback:
relevant file
plugins/plausible/config.d.ts
suggestion
Correct the typo in the property name from soureDomain to sourceDomain to ensure consistency and avoid potential runtime errors. [important]
Why: Correcting a typo in a property name is crucial to prevent potential bugs and ensure consistency across the codebase.
10
Enhancement
Add error logging for missing configuration to enhance debugging and reliability
Add error handling or logging when dataDomain or sourceDomain are not provided, to aid in debugging and ensure the application behaves as expected in error scenarios.
Why: Enhancing test coverage to verify behavior when configuration domains are missing is beneficial for ensuring the component handles edge cases correctly.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Configuration changes, Other
Description
domain
todataDomain
and addingsourceDomain
.PlausibleAnalytics
component to use new configuration properties and modified script source URL..release-it.json
configuration file.plausible
feature in the main app configuration.Changes walkthrough 📝
config.d.ts
Update Plausible configuration properties
plugins/plausible/config.d.ts
domain
property todataDomain
sourceDomain
propertyPlausibleAnalytics.tsx
Refactor PlausibleAnalytics component for new configuration
plugins/plausible/src/components/PlausibleAnalytics.tsx
dataDomain
andsourceDomain
propertiessourceDomain
plugin.test.tsx
Update plugin test cases for new configuration
plugins/plausible/src/plugin.test.tsx
.env.example
Update environment variable names
.env.example
app-config.production.yaml
Update production app configuration for Plausible
app-config.production.yaml
enabled
,dataDomain
, andsourceDomain
fields underplausible
app-config.yaml
Disable Plausible feature in app configuration
app-config.yaml
plausible
featuredomain
field.release-it.json
Remove unused .release-it.json file
.release-it.json