Skip to content

Feature/homepage #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2024
Merged

Feature/homepage #3

merged 9 commits into from
Jun 9, 2024

Conversation

johnnyhuy
Copy link
Contributor

@johnnyhuy johnnyhuy commented Jun 8, 2024 •
edited by echohello-codium-ai-pr-agent bot
Loading

PR Type

Enhancement, Bug fix, Documentation

Description

  • Added HomePage component as the default route in App.tsx.
  • Updated theme configuration to use the new HelloWorld theme.
  • Refactored and updated LogoFull and LogoIcon components with new SVG paths and attributes.
  • Updated sidebar navigation icons and fixed link destination for Home sidebar item in Root component.
  • Added initial HomePage component with a welcome message.
  • Created HelloWorld.ts theme file with custom theme options and components.
  • Added @backstage/plugin-home dependency to package.json.

Changes walkthrough 📝

Relevant files
Enhancement
App.tsx
Update routing and theme configuration in App component. 

packages/app/src/App.tsx

  • Removed unused Navigate import.
  • Added HomePage component as the default route.
  • Updated theme configuration to use HelloWorld.
    		•  +8/-6     
    LogoFull.tsx
    Refactor and update LogoFull component.                                   

    packages/app/src/components/Root/LogoFull.tsx

  • Refactored SVG structure and styling.
  • Updated logo design with new paths and attributes.
    		•  +57/-6   
    LogoIcon.tsx
    Refactor and update LogoIcon component.                                   

    packages/app/src/components/Root/LogoIcon.tsx

  • Refactored SVG structure and styling.
  • Updated logo icon design with new paths and attributes.
    		•  +20/-6   
    Root.tsx
    Update sidebar navigation and styling in Root component. 

    packages/app/src/components/Root/Root.tsx

  • Updated sidebar navigation icons.
  • Changed SidebarLogoLink styling from marginLeft to paddingLeft.
  • Fixed link destination for Home sidebar item.
    		•  +16/-21 
    HomePage.tsx
    Add initial HomePage component.                                                   

    packages/app/src/components/home/HomePage.tsx

    • Added initial HomePage component with a welcome message.
    		 +6/-0     
    HelloWorld.ts
    Implement custom theme options in HelloWorld theme.           

    packages/app/src/theme/HelloWorld.ts

  • Created new theme file HelloWorld.ts.
  • Defined custom theme options and components.
    		•  +70/-0   
    Dependencies
    package.json
    Add @backstage/plugin-home dependency.                                     

    packages/app/package.json

    • Added @backstage/plugin-home dependency.
    		 +1/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    johnnyhuy added 9 commits June 8, 2024 21:39
    @johnnyhuy
    Add initial homepage component and update theme configuration
    dccb9f0
    @johnnyhuy
    Add HomePage component as the default route in App.tsx
    cb5fabc
    @johnnyhuy
    Merge branch 'feature/mui-upgrade' into feature/homepage
    6a44e07
    @johnnyhuy
    Merge branch 'feature/mui-upgrade' into feature/homepage
    7900bc2
    @johnnyhuy
    fix: Update sidebar navigation links and dependencies in App components
    cc223cb 
    - Fixed link destination for Home sidebar item in Root component
- Removed unused import for `Navigate` in App component
    @johnnyhuy
    Implement new theme options and components into app.
    33cbd6f 
    - Create a new file `HelloWorld.ts` under `packages/app/src/theme`
- Define the `HelloWorld` constant with specific theme options and components
- Remove unnecessary import of `themes` from `@backstage/theme`
    @johnnyhuy
    style: Refactor styling in Root components
    c79b776 
    - Refactor styling in `Root.tsx` to use `paddingLeft` instead of `marginLeft` for `SidebarLogoLink`
- Update `LogoIcon.tsx` and `LogoFull.tsx` components for consistency with styling changes in `Root.tsx`
    @johnnyhuy
    feat: Update sidebar menu icons in Root.tsx
    9e280f1 
    - Revamped sidebar menu icons:
    @johnnyhuy
    Merge branch 'main' of github.com:echohello-dev/backstage into featur…
    deff912 
    …e/homepage
    @echohello-codium-ai-pr-agent echohello-codium-ai-pr-agent bot added documentation Improvements or additions to documentation enhancement New feature or request Bug fix Review effort [1-5]: 3 labels Jun 8, 2024
    @echohello-codium-ai-pr-agent
    Copy link
    Contributor

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    3, because the PR involves multiple changes across different components and files, including updates to theme configuration, routing, and UI components. The changes are moderate in size and complexity, requiring a detailed review to ensure consistency and functionality.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Possible Bug: The removal of SidebarScrollWrapper in Root.tsx might affect the scrolling behavior of the sidebar. Ensure that the sidebar still functions correctly with the new changes.

    Styling Consistency: The changes in SVG paths and attributes in LogoFull.tsx and LogoIcon.tsx need to be reviewed for visual consistency across different browsers and resolutions.

    🔒 Security concerns

    No

    @echohello-codium-ai-pr-agent
    Copy link
    Contributor

    Failed to generate code suggestions for PR

    @johnnyhuy johnnyhuy merged commit 47f1fa2 into main Jun 9, 2024
    @johnnyhuy johnnyhuy deleted the feature/homepage branch June 9, 2024 09:51
    johnnyhuy added a commit that referenced this pull request Jun 30, 2024
    @johnnyhuy
    Merge pull request #3 from echohello-dev/feature/homepage
    9e289a7 
    Feature/homepage
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    Bug fix documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 3
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @johnnyhuy