Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handlers implementation for org.eclipse.birt.report.designer.ui.preview.web #785

Closed
ruspl-afed opened this issue Jan 23, 2022 · 0 comments · Fixed by #786
Closed

Improve handlers implementation for org.eclipse.birt.report.designer.ui.preview.web #785

ruspl-afed opened this issue Jan 23, 2022 · 0 comments · Fixed by #786
Assignees
@ruspl-afed
Milestone
4.9

Comments

@ruspl-afed
Copy link
Contributor

We had a discussion with @claesrosell regarding implementation of handlers.

Here I would like to provide code changes to illustrate my point of view
@ruspl-afed ruspl-afed self-assigned this Jan 23, 2022
ruspl-afed added a commit that referenced this issue Jan 23, 2022
@ruspl-afed
Improvements for org.eclipse.birt.report.designer.ui.preview.web #785
def5a4b 
Part I:
Move handlers to internal package with classic name
Declare this package as x-internal
Add abstract handler implementation that will supply the standard
workflow
Keep only the specific "action" code for concrete handler

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit that referenced this issue Jan 27, 2022
@ruspl-afed
Merge pull request #786 from eclipse/785-1
5249abe 
Improvements for org.eclipse.birt.report.designer.ui.preview.web #785
@wimjongman wimjongman linked a pull request Jan 30, 2022 that will close this issue
Improvements for org.eclipse.birt.report.designer.ui.preview.web #785 #786
Merged
@wimjongman wimjongman added this to the 4.9 milestone Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
4.9
Development

Successfully merging a pull request may close this issue.

Improvements for org.eclipse.birt.report.designer.ui.preview.web #785 eclipse-birt/birt
2 participants
@wimjongman @ruspl-afed