Improvements for org.eclipse.birt.report.designer.ui.preview.web #785 #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part I: Move handlers to internal package with classic name Declare this package as x-internal Add abstract handler implementation that will supply the standard workflow Keep only the specific "action" code for concrete handler Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
|
@claesrosell please have a look and leave your comment |
|
I have no strong opinions about these changes. They look fine to me. 👍 |
|
Thank you for review @claesrosell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part I:
Move handlers to internal package with classic name
Declare this package as x-internal
Add abstract handler implementation that will supply the standard
workflow
Keep only the specific "action" code for concrete handler
Signed-off-by: Alexander Fedorov alexander.fedorov@arsysop.ru