-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CustomResourceDefinition for Kubernetes component in Devfiles #14843
Comments
Not sure about the prio, but handling crd's sounds important. |
I'm not sure but I assume that only cluster admin is able to register CRD on the cluster, if it's true - then we are not able to allow CRD in Devfile (CR yes, but not CRDs) since typically Che User may have admin rights for some k8s namespaces but not cluster-admin rights. @davidfestal Could you share your knowledge in this area, can we somehow create CRD with namespace admin rights (not cluster rights)? |
I think we should precise the real use-case for this need. I don't think it is expected to be installed by a runtime component such as a workspace. @apupier Can you precise a bit your use-case ? |
OTOH if you would like to add a Camel custom resource of kind |
my use case:
I created a brief for the higher level use case: https://docs.google.com/document/d/1EUefd78aJLD8FlQlyvv3cszRzr5AR-ymJ6JfsCOjd1s/edit?usp=sharing |
So I assume it's more about creating a Custom Resource than creating a Custom Resource Definition. |
I don't think so. In the devfile, what we want is to provide the Camel K instance so that users can deploy a Camel K integration during development inside the workspace. |
Could you provide a concrete example ? |
not sure which example you are looking for, but let's try :-) to install Camel K, you need to call the Kamel cli "kamel install". https://github.com/apache/camel-k#installation |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Is your enhancement related to a problem? Please describe.
I would like to provide a Camel K instance in the workspace through the devfile. Unfortunately, it requires CustomResourceDefinition which is not supported.
If for instance you add this component in the devfile:
there is this error:
Error: Failed to start the workspace: "Found unknown object type in recipe -- name: 'integrationplatforms.camel.apache.org', kind: 'CustomResourceDefinition'
Based on this code, the CustomResourceDefinition is not handled:
https://github.com/eclipse/che/blob/1907b041c137dd45f8b9ae20a4a4ba3231438054/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/environment/KubernetesEnvironmentFactory.java#L107-L127
Describe the solution you'd like
Be able to reference CustomResourceDefinition yaml file and have it deployed.
Describe alternatives you've considered
alternative is to ask user to deploy by hand.
Additional context
required to go to last iteration of Camel K stack in Che #14831
The text was updated successfully, but these errors were encountered: