Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is vortexddslauncher? #3

Closed
kartben opened this issue May 29, 2018 · 2 comments
Closed

Where is vortexddslauncher? #3

kartben opened this issue May 29, 2018 · 2 comments
Labels
question Explanation on code or feature is requested

Comments

@kartben
Copy link
Contributor

kartben commented May 29, 2018

The documentation refers to the vortexddslauncher (and the presence of the launcher is also used by the fog05 config scripts, btw) but it looks likes this launcher is not part of Eclipse Cyclone DDS, or is it?

/cc @kydos

@b3em
Copy link

b3em commented Jun 4, 2018

@kartben you're correct, at the moment the launcher is not part of Eclipse Cyclone DDS. It will be added in the future, but no time frame known yet.

@kartben
Copy link
Contributor Author

kartben commented Jun 4, 2018

@michielb-adlink Thanks for the answer. Could someone then look at fixing the documentation? It just sounds wrong to tell people to use something that just doesn't exist (yet?) :-)
Thanks!

b3em pushed a commit that referenced this issue Jun 4, 2018
As the launcher is not yet released to the community, remove the references
to if from the documentation
@b3em b3em added the question Explanation on code or feature is requested label Jun 13, 2018
@b3em b3em self-assigned this Jun 13, 2018
@b3em b3em closed this as completed Jun 13, 2018
hsgwa pushed a commit to hsgwa/cyclonedds that referenced this issue Feb 9, 2021
…edds#3)

The graph guard condition is triggered whenever the underlying DDS
topology changes using a listener set on readers for the DDS built-in
topics.  The graph guard condition was destroyed before ensuring the listeners
would no longer be invoked, and this would lead to trying to trigger the
graph guard condition after it had been destroyed.

With this commit, the built-in readers are deleted explicitly before
destroying the graph guard condition.
hsgwa pushed a commit to hsgwa/cyclonedds that referenced this issue Feb 9, 2021
As std::string is not a basic type, "new" must sometimes be called to
initialze the memory before passing it as a reference.
eboasson added a commit to eboasson/cyclonedds that referenced this issue Dec 7, 2023
This fixes a global buffer overflow (underflow?) reported by ASAN as
follows:

==93535==ERROR: AddressSanitizer: global-buffer-overflow on address \
  0x000100144e3f at pc 0x000100084424 bp 0x00016fdfd380 sp 0x00016fdfd378
READ of size 1 at 0x000100144e3f thread T0
    #0 0x100084420 in put_a_line main.c:975
    #1 0x100082974 in putout main.c:895
    eclipse-cyclonedds#2 0x100080ab4 in mcpp_main main.c:753
    eclipse-cyclonedds#3 0x10007d3fc in mcpp_lib_main main.c:430
    eclipse-cyclonedds#4 0x10000a230 in idlc_parse idlc.c:375
    eclipse-cyclonedds#5 0x100006f1c in main idlc.c:772
    eclipse-cyclonedds#6 0x181d51054  (<unknown module>)

0x000100144e3f is located 1 bytes before global variable 'output' \
  defined in '/Users/erik/C/cdds/src/tools/idlpp/src/main.c' (0x100144e40) of size 262144
0x000100144e3f is located 23 bytes after global variable 'src_col' \
  defined in '/Users/erik/C/cdds/src/tools/idlpp/src/main.c' (0x100144e20) of size 8

Triggered by the following input:

hexdump -C ~/Downloads/asan-global-bof.idl
00000000  23 fc ff 0a 23 64 65 66  69 6e 65 20 69 0a 23 64  |#...#define i.#d|
00000010  65 66 69 6e 65 20 4a 00  0a 20 4a 00 0a 23 64 69  |efine J.. J..#di|
00000020  44 66 7f f8 ff ff 66 00  32 44 0a 23 64 69 69 6e  |Df....f.2D.#diin|
00000030  65 20 4a 32 32 32 44 12  64 27 ff 7f ff 23 3e 69  |e J222D.d'...#>i|
00000040  0a                                                |.|
00000041

(I gave up trying to reduce it further.)

The problem is caused by scanning for the last non-whitespace character
just before outputting a line without accounting for the case where the
line consists solely of whitespace.

Credits for finding the bug:
- Carlos Andres Ramirez (https://carlos.engineer)
- Goktug Serez (https://github.com/g0ku704)
- Xin Huang (https://github.com/xinhuang)

Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson added a commit to eboasson/cyclonedds that referenced this issue Dec 8, 2023
This fixes a global buffer overflow (underflow?) reported by ASAN as
follows:
```
ERROR: AddressSanitizer: global-buffer-overflow on address \
  0x000100144e3f at pc 0x000100084424 bp 0x00016fdfd380 sp 0x00016fdfd378
READ of size 1 at 0x000100144e3f thread T0
    #0 0x100084420 in put_a_line main.c:975
    #1 0x100082974 in putout main.c:895
    eclipse-cyclonedds#2 0x100080ab4 in mcpp_main main.c:753
    eclipse-cyclonedds#3 0x10007d3fc in mcpp_lib_main main.c:430
    eclipse-cyclonedds#4 0x10000a230 in idlc_parse idlc.c:375
    eclipse-cyclonedds#5 0x100006f1c in main idlc.c:772
    eclipse-cyclonedds#6 0x181d51054  (<unknown module>)

0x000100144e3f is located 1 bytes before global variable 'output' \
  defined in 'src/tools/idlpp/src/main.c' (0x100144e40) of size 262144
0x000100144e3f is located 23 bytes after global variable 'src_col' \
  defined in 'src/tools/idlpp/src/main.c' (0x100144e20) of size 8
```

Triggered by the following input (`hexdump -C` output):
```
00000000  23 fc ff 0a 23 64 65 66  69 6e 65 20 69 0a 23 64  |#...#define i.#d|
00000010  65 66 69 6e 65 20 4a 00  0a 20 4a 00 0a 23 64 69  |efine J.. J..#di|
00000020  44 66 7f f8 ff ff 66 00  32 44 0a 23 64 69 69 6e  |Df....f.2D.#diin|
00000030  65 20 4a 32 32 32 44 12  64 27 ff 7f ff 23 3e 69  |e J222D.d'...#>i|
00000040  0a                                                |.|
00000041
```
(I tried to reduce it further, but gave up.)

The problem is caused by scanning for the last non-whitespace character
just before outputting a line without accounting for the case where the
line consists solely of whitespace.

Credits for finding the bug:
- Carlos Andres Ramirez (https://carlos.engineer)
- Goktug Serez (https://github.com/g0ku704)
- Xin Huang (https://github.com/xinhuang)

Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson added a commit to eboasson/cyclonedds that referenced this issue Dec 8, 2023
This fixes a global buffer overflow (underflow?) reported by ASAN as
follows:

ERROR: AddressSanitizer: global-buffer-overflow on address \
  0x000100144e3f at pc 0x000100084424 bp 0x00016fdfd380 sp 0x00016fdfd378
READ of size 1 at 0x000100144e3f thread T0
    #0 0x100084420 in put_a_line main.c:975
    #1 0x100082974 in putout main.c:895
    eclipse-cyclonedds#2 0x100080ab4 in mcpp_main main.c:753
    eclipse-cyclonedds#3 0x10007d3fc in mcpp_lib_main main.c:430
    eclipse-cyclonedds#4 0x10000a230 in idlc_parse idlc.c:375
    eclipse-cyclonedds#5 0x100006f1c in main idlc.c:772
    eclipse-cyclonedds#6 0x181d51054  (<unknown module>)

0x000100144e3f is located 1 bytes before global variable 'output' \
  defined in 'src/tools/idlpp/src/main.c' (0x100144e40) of size 262144
0x000100144e3f is located 23 bytes after global variable 'src_col' \
  defined in 'src/tools/idlpp/src/main.c' (0x100144e20) of size 8

Triggered by the following input ("hexdump -C" output):
00000000  23 fc ff 0a 23 64 65 66  69 6e 65 20 69 0a 23 64  |#...#define i.#d|
00000010  65 66 69 6e 65 20 4a 00  0a 20 4a 00 0a 23 64 69  |efine J.. J..#di|
00000020  44 66 7f f8 ff ff 66 00  32 44 0a 23 64 69 69 6e  |Df....f.2D.#diin|
00000030  65 20 4a 32 32 32 44 12  64 27 ff 7f ff 23 3e 69  |e J222D.d'...#>i|
00000040  0a                                                |.|
00000041
(I tried to reduce it further, but gave up.)

The problem is caused by scanning for the last non-whitespace character
just before outputting a line without accounting for the case where the
line consists solely of whitespace.

Credits for finding the bug:
- Carlos Andres Ramirez (https://carlos.engineer)
- Goktug Serez (https://github.com/g0ku704)
- Xin Huang (https://github.com/xinhuang)

Signed-off-by: Erik Boasson <eb@ilities.com>
mvandenhoek pushed a commit to mvandenhoek/cyclonedds that referenced this issue Jun 21, 2024
…ular_dependencies_branch

Resolve build-time circular dependencies by making the durability cli…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Explanation on code or feature is requested
Projects
None yet
Development

No branches or pull requests

2 participants