Change cmake files to make documentation optional #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Masselink <patrick.masselink@adlinktech.com>
Signed-off-by: Patrick Masselink <patrick.masselink@adlinktech.com>
Signed-off-by: Patrick Masselink <patrick.masselink@adlinktech.com>
eboasson
added a commit
to eboasson/cyclonedds
that referenced
this pull request
Jun 15, 2021
Second attempt at dealing with these false positives. Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
added a commit
that referenced
this pull request
Jun 16, 2021
Second attempt at dealing with these false positives. Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
added a commit
to eboasson/cyclonedds
that referenced
this pull request
Dec 7, 2023
This fixes a global buffer overflow (underflow?) reported by ASAN as
follows:
==93535==ERROR: AddressSanitizer: global-buffer-overflow on address \
0x000100144e3f at pc 0x000100084424 bp 0x00016fdfd380 sp 0x00016fdfd378
READ of size 1 at 0x000100144e3f thread T0
#0 0x100084420 in put_a_line main.c:975
#1 0x100082974 in putout main.c:895
eclipse-cyclonedds#2 0x100080ab4 in mcpp_main main.c:753
eclipse-cyclonedds#3 0x10007d3fc in mcpp_lib_main main.c:430
eclipse-cyclonedds#4 0x10000a230 in idlc_parse idlc.c:375
eclipse-cyclonedds#5 0x100006f1c in main idlc.c:772
eclipse-cyclonedds#6 0x181d51054 (<unknown module>)
0x000100144e3f is located 1 bytes before global variable 'output' \
defined in '/Users/erik/C/cdds/src/tools/idlpp/src/main.c' (0x100144e40) of size 262144
0x000100144e3f is located 23 bytes after global variable 'src_col' \
defined in '/Users/erik/C/cdds/src/tools/idlpp/src/main.c' (0x100144e20) of size 8
Triggered by the following input:
hexdump -C ~/Downloads/asan-global-bof.idl
00000000 23 fc ff 0a 23 64 65 66 69 6e 65 20 69 0a 23 64 |#...#define i.#d|
00000010 65 66 69 6e 65 20 4a 00 0a 20 4a 00 0a 23 64 69 |efine J.. J..#di|
00000020 44 66 7f f8 ff ff 66 00 32 44 0a 23 64 69 69 6e |Df....f.2D.#diin|
00000030 65 20 4a 32 32 32 44 12 64 27 ff 7f ff 23 3e 69 |e J222D.d'...#>i|
00000040 0a |.|
00000041
(I gave up trying to reduce it further.)
The problem is caused by scanning for the last non-whitespace character
just before outputting a line without accounting for the case where the
line consists solely of whitespace.
Credits for finding the bug:
- Carlos Andres Ramirez (https://carlos.engineer)
- Goktug Serez (https://github.com/g0ku704)
- Xin Huang (https://github.com/xinhuang)
Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
added a commit
to eboasson/cyclonedds
that referenced
this pull request
Dec 8, 2023
This fixes a global buffer overflow (underflow?) reported by ASAN as
follows:
```
ERROR: AddressSanitizer: global-buffer-overflow on address \
0x000100144e3f at pc 0x000100084424 bp 0x00016fdfd380 sp 0x00016fdfd378
READ of size 1 at 0x000100144e3f thread T0
#0 0x100084420 in put_a_line main.c:975
#1 0x100082974 in putout main.c:895
eclipse-cyclonedds#2 0x100080ab4 in mcpp_main main.c:753
eclipse-cyclonedds#3 0x10007d3fc in mcpp_lib_main main.c:430
eclipse-cyclonedds#4 0x10000a230 in idlc_parse idlc.c:375
eclipse-cyclonedds#5 0x100006f1c in main idlc.c:772
eclipse-cyclonedds#6 0x181d51054 (<unknown module>)
0x000100144e3f is located 1 bytes before global variable 'output' \
defined in 'src/tools/idlpp/src/main.c' (0x100144e40) of size 262144
0x000100144e3f is located 23 bytes after global variable 'src_col' \
defined in 'src/tools/idlpp/src/main.c' (0x100144e20) of size 8
```
Triggered by the following input (`hexdump -C` output):
```
00000000 23 fc ff 0a 23 64 65 66 69 6e 65 20 69 0a 23 64 |#...#define i.#d|
00000010 65 66 69 6e 65 20 4a 00 0a 20 4a 00 0a 23 64 69 |efine J.. J..#di|
00000020 44 66 7f f8 ff ff 66 00 32 44 0a 23 64 69 69 6e |Df....f.2D.#diin|
00000030 65 20 4a 32 32 32 44 12 64 27 ff 7f ff 23 3e 69 |e J222D.d'...#>i|
00000040 0a |.|
00000041
```
(I tried to reduce it further, but gave up.)
The problem is caused by scanning for the last non-whitespace character
just before outputting a line without accounting for the case where the
line consists solely of whitespace.
Credits for finding the bug:
- Carlos Andres Ramirez (https://carlos.engineer)
- Goktug Serez (https://github.com/g0ku704)
- Xin Huang (https://github.com/xinhuang)
Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
added a commit
to eboasson/cyclonedds
that referenced
this pull request
Dec 8, 2023
This fixes a global buffer overflow (underflow?) reported by ASAN as
follows:
ERROR: AddressSanitizer: global-buffer-overflow on address \
0x000100144e3f at pc 0x000100084424 bp 0x00016fdfd380 sp 0x00016fdfd378
READ of size 1 at 0x000100144e3f thread T0
#0 0x100084420 in put_a_line main.c:975
#1 0x100082974 in putout main.c:895
eclipse-cyclonedds#2 0x100080ab4 in mcpp_main main.c:753
eclipse-cyclonedds#3 0x10007d3fc in mcpp_lib_main main.c:430
eclipse-cyclonedds#4 0x10000a230 in idlc_parse idlc.c:375
eclipse-cyclonedds#5 0x100006f1c in main idlc.c:772
eclipse-cyclonedds#6 0x181d51054 (<unknown module>)
0x000100144e3f is located 1 bytes before global variable 'output' \
defined in 'src/tools/idlpp/src/main.c' (0x100144e40) of size 262144
0x000100144e3f is located 23 bytes after global variable 'src_col' \
defined in 'src/tools/idlpp/src/main.c' (0x100144e20) of size 8
Triggered by the following input ("hexdump -C" output):
00000000 23 fc ff 0a 23 64 65 66 69 6e 65 20 69 0a 23 64 |#...#define i.#d|
00000010 65 66 69 6e 65 20 4a 00 0a 20 4a 00 0a 23 64 69 |efine J.. J..#di|
00000020 44 66 7f f8 ff ff 66 00 32 44 0a 23 64 69 69 6e |Df....f.2D.#diin|
00000030 65 20 4a 32 32 32 44 12 64 27 ff 7f ff 23 3e 69 |e J222D.d'...#>i|
00000040 0a |.|
00000041
(I tried to reduce it further, but gave up.)
The problem is caused by scanning for the last non-whitespace character
just before outputting a line without accounting for the case where the
line consists solely of whitespace.
Credits for finding the bug:
- Carlos Andres Ramirez (https://carlos.engineer)
- Goktug Serez (https://github.com/g0ku704)
- Xin Huang (https://github.com/xinhuang)
Signed-off-by: Erik Boasson <eb@ilities.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.