Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the build and cleanup the repository content #2

Merged
merged 1 commit into from May 31, 2023
Merged

Modernize the build and cleanup the repository content #2

merged 1 commit into from May 31, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented May 30, 2023

#1

@merks
Copy link
Contributor Author

merks commented May 30, 2023

I've done an initial build of this PR request here:

https://download.eclipse.org/datatools/updates

@merks merks requested a review from sbouchet May 30, 2023 11:24
@merks
Copy link
Contributor Author

merks commented May 30, 2023

@sbouchet

I've created a pull request with all the changes. I've also configured this job:

https://ci.eclipse.org/datatools/job/build-test

It has produced this nightly build:

https://download.eclipse.org/datatools/updates/nightly/N202305301104

I would really like to contribute a milestone build of these changes to SimRel for RC1 this week, if at all possible...

@sbouchet
Copy link
Contributor

checking and validating ASAP.

@merks
Copy link
Contributor Author

merks commented May 31, 2023

I'll do the squash and merge when you give me the green light. Let's avoid creating merge commits in general...

@sbouchet
Copy link
Contributor

yes, i agree with squash/merge strategy

sbouchet
sbouchet approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrall code LGTM. can build locally, CI build is fine, updatesite produced looks good.

@sbouchet sbouchet linked an issue May 31, 2023 that may be closed by this pull request
Modernize the build and cleanup the repository content #1
Closed
@merks
Copy link
Contributor Author

merks commented May 31, 2023

@sbouchet

So I can squash and merge? 😃

I will provide an Oomph setup immediately afterward, update the README and such...

@sbouchet
Copy link
Contributor

@sbouchet

So I can squash and merge? smiley

Sure ! 👍

I will provide an Oomph setup immediately afterward, update the README and such...

@merks merks merged commit 7d0cd38 into eclipse-datatools:master May 31, 2023
1 check passed
@merks merks deleted the issue-1 branch May 31, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modernize the build and cleanup the repository content
2 participants
@merks @sbouchet