Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 546311 - [code mining] Parameter name annotations not shown when parameter value contains it #1437

Closed
jjohnstn opened this issue Jun 3, 2024 · 0 comments · Fixed by #1441
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jjohnstn
Copy link
Contributor

jjohnstn commented Jun 3, 2024

Code mining parameters are skipped when the passed parameter name is a substring of the passed parameter. For example,

public void foo(int a, int b, int c) {
}

public void foo2(int abc) {
   foo(abc, abc, abc); <== this line will show no parameter names because a, b, and c can be found in all the parameter names
}

The parameter name should only be dropped if it is an exact/lower-case match. An option can be added to filter out partial name matches.

@jjohnstn jjohnstn self-assigned this Jun 3, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Jun 3, 2024
@jjohnstn jjohnstn added this to the 4.33 M1 milestone Jun 3, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Jun 6, 2024
- add two new preferences regarding the default filter and the
  filtering of implied parameter names
- for filtering of implied parameter names, do not filter out
  parameter names that are 3 characters or less that are contained
  in the argument but filter them out if they are equal
- bump up jdt.ui minor version as new preference constants are added
- fixes eclipse-jdt#1437
@jjohnstn jjohnstn moved this to Pending review in Java Tooling Jun 6, 2024
jjohnstn added a commit that referenced this issue Jun 7, 2024
- add two new preferences regarding the default filter and the
  filtering of implied parameter names
- for filtering of implied parameter names, do not filter out
  parameter names that are 3 characters or less that are contained
  in the argument but filter them out if they are equal
- bump up jdt.ui minor version as new preference constants are added
- fixes #1437
@github-project-automation github-project-automation bot moved this from Pending review to Done in Java Tooling Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant