Fix code mining parameter name logic #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add two new preferences regarding the default filter and the filtering of implied parameter names - for filtering of implied parameter names, do not filter out parameter names that are 3 characters or less that are contained in the argument but filter them out if they are equal - bump up jdt.ui minor version as new preference constants are added - fixes eclipse-jdt#1437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the filtering logic for code mining parameter names so parameter names that are single character aren't
matched if the argument contains that character. Also added preferences to users can turn off filtering if desired.
How to test
See original bug or issue.
Author checklist