-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Langium + Monaco Tutorials #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you. Just some minor findings, comments and correction proposals.
montymxb
force-pushed
the
feature/update-langium-monaco-tuts
branch
from
October 19, 2023 15:25
7aa7715
to
365d0ad
Compare
kaisalmen
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
emilkrebs
pushed a commit
that referenced
this pull request
Oct 25, 2023
* update of langium + monaco tutorial * update generation in the web tutorial
emilkrebs
added a commit
that referenced
this pull request
Oct 26, 2023
* fixed nested elements and scaling * remaned one function * fixed a renaming problem * Fix typo in getting-started grammar (#198) * Fix typo in getting-started grammar * Make code blocks vertically scrollable To make it possible to read the docs on a phone * Update Langium + Monaco Tutorials (#192) * update of langium + monaco tutorial * update generation in the web tutorial * Update to latest monaco-editor-wrapper and monaco-editor-react (#196) * Update to latest monaco-editor-wrapper and monaco-editor-react * Implemented review comments * fixed a renaming problem --------- Co-authored-by: Vit Gottwald <vit.gottwald@gmail.com> Co-authored-by: Benjamin Friedman Wilson <benjamin.wilson@typefox.io> Co-authored-by: Kai Salmen <kai.salmen@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the last couple of tutorials for Langium + Monaco & Generation in the Web to use more recent versions of Langium (2.0.2) and the MEW (3.1.0). This follows the recent changes to langium-minilogo to version 2.0.0, which serves as the basis for a good chunk of these tutorials as well.
It would be great to get suggestions for wording and general flow improvements; as well as any typos that snuck in.
As a side note, I've noticed code-blocks are not overflowing as expected (instead of scrolling along the horizontal, they simply overflow past the right-hand boundary). This is not ideal, and appears to be a CSS issue, but is unrelated to the changes here.