Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Langium + Monaco Tutorials #192

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Oct 5, 2023

This updates the last couple of tutorials for Langium + Monaco & Generation in the Web to use more recent versions of Langium (2.0.2) and the MEW (3.1.0). This follows the recent changes to langium-minilogo to version 2.0.0, which serves as the basis for a good chunk of these tutorials as well.

It would be great to get suggestions for wording and general flow improvements; as well as any typos that snuck in.

As a side note, I've noticed code-blocks are not overflowing as expected (instead of scrolling along the horizontal, they simply overflow past the right-hand boundary). This is not ideal, and appears to be a CSS issue, but is unrelated to the changes here.

@montymxb montymxb marked this pull request as ready for review October 5, 2023 14:59
Copy link
Contributor

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you. Just some minor findings, comments and correction proposals.

hugo/content/tutorials/langium_and_monaco.md Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Outdated Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Outdated Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Outdated Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Outdated Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Outdated Show resolved Hide resolved
hugo/content/tutorials/langium_and_monaco.md Outdated Show resolved Hide resolved
hugo/content/tutorials/generation_in_the_web.md Outdated Show resolved Hide resolved
@kaisalmen
Copy link
Contributor

@montymxb it would be best to align this with #196 (=update/align tutorial after merge)

@montymxb montymxb force-pushed the feature/update-langium-monaco-tuts branch from 7aa7715 to 365d0ad Compare October 19, 2023 15:25
Copy link
Contributor

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@montymxb montymxb merged commit 89ed9f2 into main Oct 20, 2023
1 of 2 checks passed
@montymxb montymxb deleted the feature/update-langium-monaco-tuts branch October 20, 2023 06:48
emilkrebs pushed a commit that referenced this pull request Oct 25, 2023
* update of langium + monaco tutorial

* update generation in the web tutorial
emilkrebs added a commit that referenced this pull request Oct 26, 2023
* fixed nested elements and scaling

* remaned one function

* fixed a renaming problem

* Fix typo in getting-started grammar (#198)

* Fix typo in getting-started grammar

* Make code blocks vertically scrollable
To make it possible to read the docs on a phone

* Update Langium + Monaco Tutorials (#192)

* update of langium + monaco tutorial

* update generation in the web tutorial

* Update to latest monaco-editor-wrapper and monaco-editor-react (#196)

* Update to latest monaco-editor-wrapper and monaco-editor-react
* Implemented review comments

* fixed a renaming problem

---------

Co-authored-by: Vit Gottwald <vit.gottwald@gmail.com>
Co-authored-by: Benjamin Friedman Wilson <benjamin.wilson@typefox.io>
Co-authored-by: Kai Salmen <kai.salmen@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants