Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default path to extension entry point #217

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix default path to extension entry point #217

merged 1 commit into from
Feb 12, 2024

Conversation

drhagen
Copy link
Contributor

@drhagen drhagen commented Jan 10, 2024

This page does not currently work out of the box when applied to the project that comes out of generator-langium because the location of the extension entry point was moved from src/extension.ts to src/extension/main.ts. This changes the documentation to match the current default location.

Copy link

github-actions bot commented Jan 10, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-02-12 11:08 UTC

@msujew msujew requested a review from montymxb January 11, 2024 11:39
@msujew
Copy link
Member

msujew commented Jan 11, 2024

Hey @drhagen thanks for the contribution,

before we can accept any contributions, please sign the Eclipse Contributor Agreement (ECA) with the same email that was used to create the commit.

@drhagen
Copy link
Contributor Author

drhagen commented Jan 15, 2024

please sign the Eclipse Contributor Agreement (ECA)

That was quite the gauntlet for a five character patch, but I think I did it.

Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction!

@spoenemann spoenemann merged commit d408a50 into eclipse-langium:main Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants