Skip to content

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 25, 2025

Follow up on #1948, which improves on the error case, in case the array hasn't even been set yet.

@msujew msujew force-pushed the msujew/fix-infix-errors branch from 72191f0 to 44a050a Compare August 25, 2025 14:31
@msujew msujew mentioned this pull request Sep 3, 2025
@msujew msujew requested a review from sailingKieler September 3, 2025 12:20
Copy link
Contributor

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took some time to understand what's going on here. Pretty cool!
A dedicated unit test would make sense, wouldn't it? Or did I overlook it?

@msujew
Copy link
Member Author

msujew commented Sep 4, 2025

@sailingKieler Added a test and updated the code. I've kept the local variable, because it just makes the code easier to read IMO.

@msujew msujew requested a review from sailingKieler September 4, 2025 10:51
Copy link
Contributor

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@msujew msujew merged commit 38d5f16 into main Sep 4, 2025
5 checks passed
@msujew msujew deleted the msujew/fix-infix-errors branch September 4, 2025 11:48
msujew added a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants