Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursions for super/sub properties #946

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 17, 2023

Closes #945

@msujew msujew added the types Types related issue label Feb 17, 2023
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments. I didn't test changes locally, so will defer to another to check. However this looks good at first glance to me.

return this.getSuperProperties(new Set());
}

private getSuperProperties(visited: Set<string>): Property[] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required in this PR necessarily, but might be a good time to add a function header detailing how this should work, and why visited is important to prevent cycles.

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: Looks good!

@msujew msujew merged commit 19ec836 into main Mar 10, 2023
@msujew msujew deleted the msujew/infinite-super-prop-recursion branch March 10, 2023 16:18
@msujew msujew added this to the v1.2.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Types related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion
2 participants