Adding readAndDispatch() in drawImage test to make the test not flaky #2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reasoning to add readAndDispatch() is to consider the case when e.gc.drawImage()'s draw request to the OS, might not have completed by the time gcCopy.copyArea() was called. Using readAndDispatch() is to ensure all OS events are processed, so there’s no pending work left.
Test Results 118 files ±0 118 suites ±0 10m 49s ⏱️ - 2m 51s For more details on these failures, see this check. Results for commit c20f104. ± Comparison against base commit 60de8f9. |
iloveeclipse
approved these changes
Sep 29, 2025
|
Windows test failures are known and unrelated, see #2516 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning to add readAndDispatch() in test_drawImage_nonAutoScalableGC_bug_2504 is to consider the case when e.gc.drawImage()'s draw request to the OS, might not have completed by the time gcCopy.copyArea() was called. Using readAndDispatch() is to ensure all OS events are processed, so there’s no pending work left.