Skip to content

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Sep 29, 2025

Since the upgrade of the default GitHub Actions runner for Windows to Windows Server 2025, the key event tests started to fail sporadically. Until a solution is found, this temporarily disables the tests to avoid that it hides actual issues when investigating the build results.

For the used system variable to identify the GHA environment, see https://docs.github.com/en/actions/reference/workflows-and-actions/variables#default-environment-variables

Contributes to #2516

Copy link
Contributor

github-actions bot commented Sep 29, 2025

Test Results

  118 files  ±0    118 suites  ±0   11m 33s ⏱️ +41s
4 582 tests ±0  4 546 ✅  - 17  36 💤 +19  0 ❌  - 2 
  330 runs  ±0    307 ✅  - 17  23 💤 +19  0 ❌  - 2 

Results for commit f2d6cf8. ± Comparison against base commit 9a317a3.

This pull request removes 22 and adds 22 tests. Note that renamed tests count towards both.
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testBengali_digits
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testBulgarian_trivialCases
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishDvorak_trivialCases
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishInternational_deadKey_Shift6
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_CtrlBreak
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_CtrlEnter_CtrlBack
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_LEDs
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_altNumpadDigitsUnicode
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_multipleLetters
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_numpad
…
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testBengali_digits
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testBulgarian_trivialCases
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishDvorak_trivialCases
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishInternational_deadKey_Shift6
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_CtrlBreak
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_CtrlEnter_CtrlBack
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_LEDs
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_altNumpadDigitsUnicode
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_multipleLetters
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_numpad
…
This pull request removes 3 skipped tests and adds 22 skipped tests. Note that renamed tests count towards both.
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_multipleLetters
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_unorderedCtrlC
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_unpairedKeyUp
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testBengali_digits
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testBulgarian_trivialCases
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishDvorak_trivialCases
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishInternational_deadKey_Shift6
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_CtrlBreak
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_CtrlEnter_CtrlBack
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_LEDs
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_altNumpadDigitsUnicode
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_multipleLetters
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_numpad
…

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the issue-2516-disablement branch 2 times, most recently from 490d0a2 to 0921abb Compare September 29, 2025 20:07
@HeikoKlare
Copy link
Contributor Author

Logs show that check for GITHUB_ACTIONS environment variable works:

Tests run: 22, Failures: 0, Errors: 0, Skipped: 22, Time elapsed: 0.002 s -- in AllWin32Tests Test_org_eclipse_swt_events_KeyEvent
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent.testBengali_digits skipped
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent.testEnglishUs_LEDs skipped
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent.testEnglishUs_CtrlEnter_CtrlBack skipped
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent.testHebrew_trivialCases skipped
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_events_KeyEvent.testLithuanian_digits skipped
...

…2516

Since the upgrade of the default GitHub Actions runner for Windows to
Windows Server 2025, the key event tests started to fail sporadically.
Until a solution is found, this temporarily disables the tests to avoid
that it hides actual issues when investigating the build results.

Contributes to
eclipse-platform#2516
@HeikoKlare HeikoKlare force-pushed the issue-2516-disablement branch from 0921abb to f2d6cf8 Compare September 29, 2025 20:23
@HeikoKlare HeikoKlare marked this pull request as ready for review September 29, 2025 20:37
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Do you plan to change something or can this PR be merged?

@HeikoKlare
Copy link
Contributor Author

Thank you for the feedback! This is ready to go from my side. I just wanted to have someone have a quick look when disabling a bunch of tests.

@HeikoKlare HeikoKlare merged commit 87fa834 into eclipse-platform:master Sep 30, 2025
17 checks passed
@HeikoKlare HeikoKlare deleted the issue-2516-disablement branch September 30, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants