Fix Carret drawing on GTK 4 #2582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooked Gtk 4 focus and draw events for Canvas to enable drawing. It is unclear why cairo_set_source_rgb actually reverses color on Gtk 4 but this makes us move a step ahead towards working editor. Tested via Snippet74.
akurtakov
added a commit
to akurtakov/eclipse.platform.swt
that referenced
this pull request
Oct 2, 2025
In eclipse-platform#2582 I've mixed the handlers. This fixes it to not call into each other.
akurtakov
added a commit
that referenced
this pull request
Oct 2, 2025
In #2582 I've mixed the handlers. This fixes it to not call into each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooked Gtk 4 focus and draw events for Canvas to enable drawing. It is unclear why cairo_set_source_rgb actually reverses color on Gtk 4 but this makes us move a step ahead towards working editor.
Tested via Snippet74.