Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to the existing dark theme #2112

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Improvement to the existing dark theme #2112

merged 4 commits into from
Jul 20, 2024

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Jul 18, 2024 •
edited
Loading

For the full details of the change including screenshots see issue: #2114

mvm-sap added 2 commits July 18, 2024 15:42
@mvm-sap
Improvement to the existing Light Theme
4319f36 
As part of Eclipse modernization project, we have enhanced the look and
feel of Eclipse IDE. This change includes improvements to the background
color of Views and working of tabs. This has been done with reference to
the other IDEs like VS Code, Intellij etc.
@mvm-sap
Improvement to the existing dark theme
c509c76 
Current dark theme has many issues with the background color and
contrasts. As a first step to improve dark theme, we have changed the
background color of the editor, making it the darkest when compared to
other views. Also, the working of tabs are made simple wrt to the
background colors and gradients. These changes were made by referring
other IDEs like VS Code and IntelliJ. Now, eclipse dark theme also looks
modern.
@iloveeclipse
Copy link
Member

Screenshots ?

@vogella
Copy link
Contributor

vogella commented Jul 18, 2024 •
edited
Loading

The sap specific styling should be done by a sap extension to the dark theme

IEclipsePreferences#org-eclipse-ui-workbench:com-sap-adt-tools-abapsource-ui {

@vogella
Copy link
Contributor

vogella commented Jul 18, 2024

Please adjust also the Linux dark theme

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 210 files   -     4   1 210 suites   - 4   1h 8m 36s ⏱️ - 8m 4s
 7 677 tests ±    0   7 445 ✅ +246  231 💤  -  2  1 ❌ +1 
16 128 runs   - 1 024  15 614 ✅  - 760  513 💤  - 10  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c509c76. ± Comparison against base commit 8534560.

This pull request skips 3 and un-skips 5 tests. 
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

@thomasritter thomasritter mentioned this pull request Jul 19, 2024
Open
13 tasks
@mvm-sap
Copy link
Contributor Author

mvm-sap commented Jul 19, 2024

Please find the screenshots in the issue link provided : #2114

@thomasritter
Copy link

thomasritter commented Jul 19, 2024 •
edited
Loading

@vogella Adjusting the themes is very expensive. It took one person 3+ months to learn about how the themes work and get the Windows and Mac themes ready. Before we adjust the Linux theme we want to be sure that the Eclipse community approves the made changes and incorporate their feedback. Once Windows and Mac are finished we are fully committed to update the Linux theme.

@vogella
Copy link
Contributor

vogella commented Jul 20, 2024

Windows errors looks unrelated, merging

@vogella vogella merged commit 95eda2b into eclipse-platform:master Jul 20, 2024
14 of 15 checks passed
@mvm-sap mvm-sap deleted the New_Dark_Theme branch July 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvm-sap @iloveeclipse @vogella @thomasritter