Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border for selected tab in views - Win and Mac #2150

Merged

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Aug 2, 2024

Missing border for selected tab in views. This is mostly visible when only one tab is selected per stack. This change also fixes issues reported w.r.t to the horizontal separator between view header and content. Also, vertical separation between tabs.
Changes are done for Mac and Win. For linux it is part of PR - #2137

Find the before and after image in windows
image

image

@mvm-sap mvm-sap changed the title Border for selected tab in views Border for selected tab in views - Win and Mac Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Test Results

 1 210 files   -   605   1 210 suites   - 605   52m 34s ⏱️ - 46m 37s
 7 684 tests ±    0   7 456 ✅ +    4  228 💤 ±  0  0 ❌  - 3 
16 142 runs   - 8 071  15 673 ✅  - 7 787  469 💤  - 280  0 ❌  - 3 

Results for commit 71fca3c. ± Comparison against base commit 60c835b.

@vogella
Copy link
Contributor

vogella commented Aug 2, 2024

Please include in this change also the update for Linux

@vogella
Copy link
Contributor

vogella commented Aug 2, 2024

I like it. @HannesWell ?

@HannesWell
Copy link
Member

I like it. @HannesWell ?

I like it as well. This change makes the separation much more clear.

Thank you.

@vogella
Copy link
Contributor

vogella commented Aug 2, 2024

Good to go, once we see the Linux update.

@BeckerWdf
Copy link
Contributor

Good to go, once we see the Linux update.

#2137 did already add this for linux.
So we can merge this one.

@BeckerWdf BeckerWdf merged commit 667a0dd into eclipse-platform:master Aug 7, 2024
15 of 16 checks passed
@BeckerWdf BeckerWdf added this to the 4.33 M3 milestone Aug 7, 2024
@mvm-sap mvm-sap deleted the Border_for_selected_tabs_in_view branch August 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants