Skip to content

Conversation

pcdavid
Copy link
Contributor

@pcdavid pcdavid commented Feb 28, 2025

No description provided.

@iloveeclipse
Copy link
Contributor

Fixes #17

@merks
Copy link
Contributor

merks commented Feb 28, 2025

FYI, this PR looks like the identical thing I did for BIRT.

eclipse-birt/birt#2031

Kudos Andrey for being the best quality tester in the universe. 🏆

@pcdavid
Copy link
Contributor Author

pcdavid commented Feb 28, 2025

A small warning: the new ZoomListener type in the org.eclipse.draw2d.zoom package was introduced in GEF Classic 3.13, so this change makes the code incompatible with earlier versions.

@iloveeclipse
Copy link
Contributor

for being the best quality tester in the universe.

Not really. I just let our developers be beta testers of 4.35 plus whatever they need, and they need latest XSD tooling + GEF. So just got this bug reported because someone was unhappy with XSD :-)

@nitind nitind merged commit 5a72562 into eclipse-sourceediting:master Feb 28, 2025
1 check passed
@nitind
Copy link
Contributor

nitind commented Feb 28, 2025

Thanks Pierre-Charles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants