-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partner network | BPDM service is not accessible #132
Comments
Hi @mounirol, thanks for opening the issue. As discussed in the EF Chat: I checked this, and AFAI can say right now, there might be a mismatch between the rights and roles concept and the bpdm implementation: the implementation excepts the read_partner role https://github.com/eclipse-tractusx/bpdm/blob/v6.0.0/bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/config/PermissionConfigProperties.kt#L28 but according the rights and role concept this role should not be assigned https://github.com/eclipse-tractusx/portal-iam/blob/v3.0.0/docs/technical%20documentation/06.%20Roles%20%26%20Rights%20Concept.md#255-bpdm-pool. I can't say if the bpdm implementation or the the R&R concept is correct, and we'll need to discuss this with @jjeroch ones she's back from vacation. |
Looking into this by today |
It was expected (and we thought successfully tested) that following assignment is enough: However this is not enough; additionally the following permission needs to get assigned: @evegufy can you take this up? |
read_partner from Cl7-CX-BPDM added |
@evegufy The Partner network is accessible from the portal, but it is not possible to access the BPDM APIs using the Technical user. Will this also be fixed? |
@mounirol could you please provide an example? |
@Sebastian-Wurm seems like the new BPDM solution is not well known to the teams. We need a user documentation for this. Please take this up. To be answered:
Note my expectation is the following:
...please confirm. @evegufy in the current state of the ticket, I suggest to move the ticket to BPDM - I dont see a technical change needed on our side. |
|
|
As far as I can see the problem is that the Portal invokes the endpoint "pool/v6/legal-entities" and receives (rightfully) a 403 since this is the endpoint to query all legal entities. Since version 6 of the API we introduced the members endpoint which returns only the Catena-X business partner member data: pool/v6/members/legal-entities/search So from the BPDM side this behaviour is expected, but the Portal would need to integrate the members endpoint instead. Users of the Portal should have the permission to view Catena-X member data but not all data. |
@Sebastian-Wurm @nicoprow If you see a need for adjustments, I suggest you open an issue in the sig-release repo with a title like "BPDM | Consolidate Rights and Roles" and mark it with the bdpm portal and prep24.12 labels, so we can refine it for the next release, the following should be made transparent on sig-release level as well #154 (comment) |
@evegufy: Best would be use the other endpoint, as @nicoprow described above. Either we do that in the reference implementation of the Portal or the Operating Company has to do that in their implementation of the Portal, if they want to provide the correct Partner Network functionality for Jupiter release. The fix with read_partner is definitely wrong, so it makes sense to remove it. Wouldn't this change in portal-iam also make a general retest necessary as IAM is a cross-cutting aspect? @maximilianong, @jjeroch any recommendations from your side? |
The provided urls do not seem to work for me , could you please verify @Sebastian-Wurm |
@MaximilianHauer the arc42 just moved folders to be compatible to the TRGs. I corrected the URLs above Permission groups are explained in the Arc42 document: https://github.com/eclipse-tractusx/bpdm/blob/main/docs/architecture/08_Crosscutting_Concepts.md#bpdm-permission-groups |
Hi all, we aligned to remove the bugfix from this release. |
Important note: @nicoprow & @evegufy please add this in the 24.08. release documentation of BPDM. Any further steps to be managed with the release 24.12. as mentioned by @MaximilianHauer |
The wrong workaround/fix with adding read_partner from Cl7-CX-BPDM to BPDM Pool Consumer did not make it into release 24.08. This issue eclipse-tractusx/portal-frontend#980 was created the api change in the portal frontend. I suggest to do the change mentioned here #132 (comment) as part of #154. With this all points of this issue should be addressed and I suggest to close this issue. |
was added to known knowns for R24.08 |
Current Behavior
We are not able to access the BPDM service. We tried with all the possible roles and permissions but none has worked for us. We get always 403.
Expected Behavior
We should be able to access the BPDM service with an appropriate role.
Steps To Reproduce
Check the Partner Network in the portal or try to access the BPDM service APIs.
The text was updated successfully, but these errors were encountered: