Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven-verifier from 1.7.2 to 1.8.0 #1257

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2022

Bumps maven-verifier from 1.7.2 to 1.8.0.

Release notes

Sourced from maven-verifier's releases.

1.8.0

⚠️ Deprecated

🚀 New features and improvements

🐛 Bug Fixes

📦 Dependency updates

📝 Documentation updates

🔧 Build

Commits
  • 48aaff7 [maven-release-plugin] prepare release maven-verifier-1.8.0
  • 431fbac [MSHARED-1048] Upgrade junit from 4.13.1 to 4.13.2
  • 6ebdc71 Bump slf4j-simple from 1.7.32 to 1.7.36
  • c6b3827 [MSHARED-1046] Upgrade Parent to 35
  • 1aacc68 Bump maven-shared-utils from 3.3.3 to 3.3.4
  • 0ae0517 [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions
  • d1c6e31 add release-drafter gh action
  • babe4ad add release-drafter setup file
  • 467caa3 add dependabot file
  • 3ce0eee Test Embedded3xLauncher with Maven Home
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Test Results

335 files   - 214  335 suites   - 214   16h 35m 42s ⏱️ + 11h 54m 49s
325 tests  -   22    53 ✔️  - 287    6 💤 ±0  1 +1  265 🔥 +264 
615 runs   - 426  157 ✔️  - 864  14 💤  - 5  5 +5  439 🔥 +438 

For more details on these failures and errors, see this check.

Results for commit 98faa3a. ± Comparison against base commit f542dbb.

This pull request removes 33 and adds 11 tests. Note that renamed tests count towards both.
org.eclipse.tycho.test.TYCHO0294ProductP2TargetPlatformResolver.ProductP2TargetPlatformResolverTest ‑ testBasic
org.eclipse.tycho.test.TYCHO109product.Tycho109ProductExportTest ‑ exportFeatureProduct
org.eclipse.tycho.test.TYCHO109product.Tycho109ProductExportTest ‑ exportPluginRcpApplication
org.eclipse.tycho.test.TYCHO109product.Tycho109ProductExportTest ‑ productNoZip
org.eclipse.tycho.test.TYCHO192sourceBundles.Tycho192SourceBundleTest ‑ testDefaultSourceBundleSuffix
org.eclipse.tycho.test.TYCHO308importSystemPackage.ImportSystemPackagesTest ‑ testLocalInstall
org.eclipse.tycho.test.TYCHO308importSystemPackage.ImportSystemPackagesTest ‑ testP2Repository
org.eclipse.tycho.test.TYCHO350ClassCastException.TYCHO350ClassCastExceptionTest ‑ test
org.eclipse.tycho.test.iu.IUMetadataGenerationTest ‑ testIUWithArtifact
org.eclipse.tycho.test.iu.IUMetadataGenerationTest ‑ testIUWithoutArtifact
…
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.iu.IUMetadataGenerationTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.BasicP2RepositoryIntegrationTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.RepoRefLocationP2RepositoryIntegrationTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.TransitiveP2RepoTest ‑ Unknown test
org.eclipse.tycho.test.product.ProductTypesTest ‑ Unknown test
org.eclipse.tycho.test.product.Tycho188P2EnabledRcpTest ‑ Unknown test
…

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from fce6f79 to 71baf8a Compare August 9, 2022 19:58
@laeubi
Copy link
Member

laeubi commented Sep 8, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 8, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@laeubi
Copy link
Member

laeubi commented Sep 8, 2022

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 71baf8a to bd0e2bd Compare September 8, 2022 05:31
@laeubi
Copy link
Member

laeubi commented Sep 8, 2022

@akurtakov @mickaelistria if this do not work, should we further investigate here or close the PR?

@akurtakov
Copy link
Member

Ideally, we should be able to update to latest verifier or if there is bad regression in it report it upstream. Unfortunately, it's very low priority thus I can't make my mind do we have to keep it just as a reminder for now.

@laeubi laeubi marked this pull request as draft September 8, 2022 14:15
@mickaelistria mickaelistria force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from bd0e2bd to 2c69eaa Compare September 12, 2022 13:53
@laeubi
Copy link
Member

laeubi commented Sep 15, 2022

@akurtakov something for 3.0 ?

@akurtakov
Copy link
Member

@dependabot recreate

@akurtakov
Copy link
Member

Not likely unless it magically starts to run our tests successfully

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 2c69eaa to 934bf62 Compare September 15, 2022 14:35
@laeubi
Copy link
Member

laeubi commented Oct 4, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 934bf62 to 536c0a5 Compare October 4, 2022 16:27
@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 536c0a5 to 7c4aaa9 Compare October 23, 2022 07:22
@akurtakov
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 7c4aaa9 to 40c7d78 Compare January 6, 2023 12:52
@laeubi
Copy link
Member

laeubi commented Feb 5, 2023

@dependabot rebase

@laeubi laeubi marked this pull request as ready for review February 5, 2023 16:52
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 40c7d78 to 32f3857 Compare February 5, 2023 16:52
@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 32f3857 to d2446a2 Compare February 23, 2023 13:52
@akurtakov
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from d2446a2 to 8bd42c4 Compare April 26, 2023 10:58
@laeubi
Copy link
Member

laeubi commented May 18, 2023

@dependabot rebase

Bumps [maven-verifier](https://github.com/apache/maven-verifier) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/apache/maven-verifier/releases)
- [Commits](apache/maven-verifier@maven-verifier-1.7.2...maven-verifier-1.8.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.shared:maven-verifier
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch from 8bd42c4 to 98faa3a Compare May 18, 2023 04:31
@laeubi
Copy link
Member

laeubi commented May 18, 2023

I see a lot of out-of memory problems here, this is maybe due to the default execution in-process instead of forking. so one possible solution would be to explicitly enable forking the test in the created Verifier instance.

@laeubi laeubi mentioned this pull request May 21, 2023
@laeubi
Copy link
Member

laeubi commented May 21, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 21, 2023

Looks like org.apache.maven.shared:maven-verifier is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 21, 2023
@dependabot dependabot bot deleted the dependabot/maven/org.apache.maven.shared-maven-verifier-1.8.0 branch May 21, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants