Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Publisher::write #819

Merged
merged 11 commits into from
Mar 13, 2024
Merged

remove Publisher::write #819

merged 11 commits into from
Mar 13, 2024

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Mar 13, 2024 •
edited
Loading

This API method is redundant, the put and delete are enough
Related to #736
Closes #731

milyin and others added 8 commits February 21, 2024 17:06
@milyin
build plugins with default zenoh features
60ba702
@p-avital
update documentation to the new api for keformat's generated Parsed (#…
6045bfe 
…783)
@fuzzypixelz
fix: Relax dependency requirements (#758)
c12c005 
- async-io
- unix-named-pipe
- filepath
- advisory-lock
@fuzzypixelz
feat: Improve release workflow (#756)
ceb982d 
* wip: Improve Release workflow

* feat: Add DockerHub & GHCR releases

* feat: Refactor checks and tests into pre-release workflow

* chore: Remove crates_check.sh and crates_publish.sh

* fix: Remove Dockerfile
@milyin
Merge branch 'main' into default_features_fix
1acb511
@milyin
Merge pull request #745 from eclipse-zenoh/default_features_fix
63965fc 
build plugins with default zenoh features
@yellowhatter
restore SN in case of frame drops caused by congestion control (#815)
1c8ed89
@milyin
remove Publisher::write
4c798fc
@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets
Copy link
Member

Mallets commented Mar 13, 2024

@milyin I suggest to target https://github.com/eclipse-zenoh/zenoh/tree/protocol_changes to minimise impact on #566 merge.

@milyin milyin changed the base branch from main to protocol_changes March 13, 2024 13:28
@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@milyin milyin linked an issue Mar 13, 2024 that may be closed by this pull request
Write in Rust Publisher should be moved to a trait #731
Closed
@milyin milyin requested a review from Mallets March 13, 2024 13:48
@Mallets Mallets merged commit cc68ffb into protocol_changes Mar 13, 2024
15 checks passed
@Mallets Mallets deleted the remove_publisher_write branch March 13, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write in Rust Publisher should be moved to a trait
6 participants
@milyin @eclipse-zenoh-bot @Mallets @p-avital @fuzzypixelz @yellowhatter