Eclipse preference Dart SDK location validation always false - wrong compare string #179
Comments
|
@Nawakland thanks for the report. Could you send a PR for the fix? |
Nawakland
added a commit
to Nawakland/dartboard
that referenced
this issue
Nov 6, 2020
Correct wrong string compare for Dart SDK location validation in Eclipse preference view. Signed-off-by: Bryan Claude Alain BERTHOU <bryan25.berthou@laposte.net>
|
@vogella What about nightly build ? Seems there is no update from commits. |
|
@Nawakland sorry for this. I look into this on Friday, the next two days are already really busy. |
|
Any solution available. Not a valid SDK Location? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today, the command dart --version return Dart SDK version: 2.10.3 [...]
So the compare string return version.startsWith("Dart VM version"); is always false/not valid line 136 from file org.eclipse.dartboard/src/org/eclipse/dartboard/preferences/DartSDKLocationFieldEditor.java
I suggest to test if the keywords "Dart" and "version" appear in the compare string (and better compare both in lower case to avoid mismatch).
Tell me when it will be available in nighty build to start working with.
Best regards,
Nawakland.
The text was updated successfully, but these errors were encountered: