Build and Package.json Fixes #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spf00
reviewed
Apr 17, 2025
package.json
Outdated
| "scripts": { | ||
| "dev": "cross-env REACT_APP_TARGET_URL=http://localhost:8080 vite", | ||
| "build": "vite build", | ||
| "build-standalone": "cross-env REACT_APP_TARGET_URL= vite build", | ||
| "build-standalone": "cross-env REACT_APP_TARGET_URL=https://eclipse.github.io/editdor/ vite build", |
There was a problem hiding this comment.
The REACT_APP_TARGET_URL is pretty much what the proxy endpoint query parameter is. So I would leave that blank here REACT_APP_TARGET_URL= such that the standalone ediTDor defaults to using the local disk to save TDs/TMs to.
If we use https://eclipse.github.io/editdor/ the ediTDor assumes to find valid Things API endpoints there.
There was a problem hiding this comment.
ok then we can completely remove the build-standalone script?
This was referenced Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting the gh pages to the new build process and also adding some basic fields to package.json