[Xtend] put INCOMPATIBLE_RETURN_TYPE marker on field's type #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a field with an active annotation like @accessors, instead of marking the whole field with error.
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 19, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 22, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 23, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 26, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Jan 30, 2024
LorenzoBettini
added a commit
to LorenzoBettini/xtext
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2349 I discovered that Xtend puts an INCOMPATIBLE_RETURN_TYPE marker on the whole field; this happens, e.g., when an active annotation like
Accessorsis put on a field in a subclass of another class; theAccessorscreates a getter or setter that might conflict with an inherited getter or setter:This PR, independently from #2349, allows the marker to be put on the incompatible type, just like it happens for overridden methods:
This PR also improves a few other Xtend tests checking also the position of the error marker. The relevant change in Xtend is this one: https://github.com/eclipse/xtext/compare/main...LorenzoBettini:lb_xtend_validation_tests?expand=1#diff-7eccd6f746520f0ceab7a1355467b7ca7009462eec0d4efa65b4e23749e40f95R886