Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerated Xbase test languages #2918

Merged

Conversation

LorenzoBettini
Copy link
Contributor

While working on #2349 , I plan to add an Xbase language to test corner cases for #2349 .

To avoid additional changes to be reviewed, I regenerated the Xbase test languages.

The regeneration only changed the copyright year

@szarnekow szarnekow added this to the Release_2.34 milestone Jan 23, 2024
@LorenzoBettini LorenzoBettini merged commit 4bf47b0 into eclipse:main Jan 23, 2024
5 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_regen-xbase-test-languages branch January 23, 2024 08:58
@cdietrich
Copy link
Member

@LorenzoBettini domain model and other xbase based samples missing intentionally?

@LorenzoBettini
Copy link
Contributor Author

@cdietrich yes: I only regenerated the languages of xbase.testlanguages for the above reasons.

@LorenzoBettini
Copy link
Contributor Author

@szarnekow I was experimenting with some of the Xbase test languages; if I start the runtime workspace, the Xbase test languages do not generate any Java code. By debugging, I can see that their inferrers are called, but no generation takes place. Is that intentional?

@cdietrich
Copy link
Member

Is jvmmodelgenerator bound?

@LorenzoBettini
Copy link
Contributor Author

Shouldn't that be automatically bound for xbase languages?

@cdietrich
Copy link
Member

cdietrich commented Jan 23, 2024

Is the builder registered in plugin XML

Shouldn't that be automatically bound for xbase languages?

and no testlanguages usually have a custom fragment zoo

how are you testing this?

@LorenzoBettini
Copy link
Contributor Author

The plugin.xml says

	<extension point="org.eclipse.xtext.builder.participant">
		<participant
			class="org.eclipse.xtext.xbase.testlanguages.bug462047.ui.Bug462047LangExecutableExtensionFactory:org.eclipse.xtext.builder.IXtextBuilderParticipant"
			fileExtensions="bug462047lang"/>
	</extension>

and the runtime module extends the Xbase module that binds JvmModelGenerator.

I start a new workbench and try to edit a file of one of the Xbase test languages. The editor works but nothing is generated, though the model inferrer is used.

What do you mean by custom fragment zoo?

@cdietrich
Copy link
Member

fragement = A {}
fragment = B {}
....

btw it works perfectly fine for me
grafik
is the file in src folder?

@LorenzoBettini
Copy link
Contributor Author

Apparently, I was using the wrong file extension, sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants