Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LSP4J 0.23.0. Fixes #2933 #3036

Merged
merged 1 commit into from
May 14, 2024
Merged

Update to LSP4J 0.23.0. Fixes #2933 #3036

merged 1 commit into from
May 14, 2024

Conversation

cdietrich
Copy link
Member

No description provided.

@cdietrich cdietrich added this to the Release_2.35 milestone May 14, 2024
Copy link
Contributor

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there also a document with dependencies to update? Or that doesn't matter for LSP?

Also for this PR, the builds for pushes on GitHub Actions haven't started...

@cdietrich
Copy link
Member Author

we update notice.md only for 2rd party deps, not eclipse ones

@cdietrich
Copy link
Member Author

@LorenzoBettini did you figure out why

@github-actions
Build / build (pull_request) Skipped

@cdietrich cdietrich merged commit 9964dba into main May 14, 2024
6 checks passed
@cdietrich cdietrich deleted the cd/lsp4j023 branch May 14, 2024 16:35
@LorenzoBettini
Copy link
Contributor

@LorenzoBettini did you figure out why

@github-actions
Build / build (pull_request) Skipped

@cdietrich the fact that build jobs for PR are skipped is expected: we implemented that for skipping PRs for internal PRs.

I don't understand why the build jobs for the PUSH are skipped... that's unexpected.

@cdietrich
Copy link
Member Author

This is what I meant

@LorenzoBettini
Copy link
Contributor

This is what I meant

Can it be that you created the edits directly from GitHub?
Just guessing...
it happened twice for you.

@cdietrich
Copy link
Member Author

No I pushed branch and immediately created pr

@LorenzoBettini
Copy link
Contributor

Then maybe you've been too fast ;)
let's see in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants