Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Edge hints are wrongly interpreted #378

Closed
planger opened this issue Sep 20, 2019 · 0 comments · Fixed by #379
Closed

Edge hints are wrongly interpreted #378

planger opened this issue Sep 20, 2019 · 0 comments · Fixed by #379
Assignees
@planger
Labels
bug Something isn't working client A issue that is heavily affecting the client part (Typescript)

Comments

@planger
Copy link
Collaborator

planger commented Sep 20, 2019

If you specify that an edge is only allowed from type A to B, the client will interpret it wrongly and show wrong feedback. It will disallow creating the edge from A. But it will allow to create the edge from elements of type B.
@planger planger added bug Something isn't working client A issue that is heavily affecting the client part (Typescript) labels Sep 20, 2019
@planger planger self-assigned this Sep 20, 2019
planger added a commit that referenced this issue Sep 20, 2019
@planger
Fix edge hint interpretation on the server
2734e19 
Fixes #378
@planger planger mentioned this issue Sep 20, 2019
Merged
tortmayr pushed a commit that referenced this issue Sep 22, 2019
@planger @tortmayr
Fix edge hint interpretatio (#379)
f38fca9 
* Fix edge hint interpretation on the client

Fixes #378

* Improve physical ordering of methods according to their logical order

I think this way it is easier to explain someone the meaning of the
respective classes.

PS: Sorry for pushing this commit into a branch, even though it is
off-topic ;)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@planger planger

Labels
bug Something isn't working client A issue that is heavily affecting the client part (Typescript)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix edge hint interpretation on the server eclipsesource/graphical-lsp
1 participant
@planger