This repository was archived by the owner on Nov 27, 2019. It is now read-only.
Add custom error messages for uischema validation #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarmueller
suggested changes
Apr 25, 2018
AhmetTanakol
force-pushed
the
custom-errors
branch
from
d8057d9 to
06fb8e9
Compare
AhmetTanakol
force-pushed
the
custom-errors
branch
from
06fb8e9 to
d238b17
Compare
|
Updated |
edgarmueller
suggested changes
Aug 1, 2018
src/models/ui-metaschema.ts
Outdated
| 'scope': 'Control scope should match pattern "^#\\/properties\\/{1}"', | ||
| 'suggestion': 'Control suggestion should be array', | ||
| 'options': 'Control options should be object', | ||
| 'label': 'Control label should be string,boolean or label object' |
There was a problem hiding this comment.
Add whitespace after comma
src/models/ui-metaschema.ts
Outdated
| }, | ||
| 'required': { | ||
| 'scope': 'Control should have an object property "scope"', | ||
| 'type': 'Control should have an object property "type"' |
There was a problem hiding this comment.
Isn't type a string -> remove 'object'?
src/models/ui-metaschema.ts
Outdated
| 'type': 'Control should have an object property "type"' | ||
| }, | ||
| 'additionalProperties': 'Control should not have properties ' + | ||
| 'other than type,label,scope,options,suggestion and rule' |
There was a problem hiding this comment.
Add whitespace after each comma
src/models/ui-metaschema.ts
Outdated
| }, | ||
| 'required': { | ||
| 'elements': 'Root should have an array property "elements"', | ||
| 'type': 'Root should have an object property "type"' |
There was a problem hiding this comment.
Should be of type string
src/models/ui-metaschema.ts
Outdated
| 'type': 'Root should have an object property "type"' | ||
| }, | ||
| 'additionalProperties': 'Root should not have properties ' + | ||
| 'other than type,elements,label and rule' |
There was a problem hiding this comment.
Whitespace after each comma
AhmetTanakol
changed the title
edgarmueller
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ajv custom error messages