-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export unwrapped material controls #1418
Export unwrapped material controls #1418
Conversation
Thanks for the PR! Just a quick suggestion: could we have an object which is providing all the unwrapped components, so usage would be something like: import { Unwrapped } from '@jsonforms/material-renderers';
const MyRenderer = () => (
<Unwrapped.MaterialTextControl ... />
) |
@Lily418 Something went wrong here. Would you like to update once more? |
Hi Edgar, I switched laptops and didn't update my email for commits yet. Going to update this PR with suggestions and re-write the email on the commits. |
Great, thank you! |
@edgarmueller updated 🚡 |
It's still complaining about the formatting, but other than that this looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Last week was talking to @eneufeld about building a custom control which reuses the MaterialTextControl.
#1413 (comment)
This is a PR to export the control components not wrapped with
withJsonFormsControlProps
so they can be used in custom renderers.