Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export unwrapped material controls #1418

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Export unwrapped material controls #1418

merged 4 commits into from
Jul 3, 2019

Conversation

Lily418
Copy link
Contributor

@Lily418 Lily418 commented Jun 25, 2019

Last week was talking to @eneufeld about building a custom control which reuses the MaterialTextControl.

#1413 (comment)

This is a PR to export the control components not wrapped with withJsonFormsControlProps so they can be used in custom renderers.

@coveralls
Copy link

coveralls commented Jun 25, 2019

Coverage Status

Coverage increased (+0.05%) to 81.392% when pulling eb81ab3 on HelixCentre:feature/export-unwrapped-material-controls into c8adb28 on eclipsesource:master.

@edgarmueller
Copy link
Contributor

Thanks for the PR! Just a quick suggestion: could we have an object which is providing all the unwrapped components, so usage would be something like:

import { Unwrapped } from '@jsonforms/material-renderers';

const MyRenderer = () => (
  <Unwrapped.MaterialTextControl ... />
)

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
All committers have signed the CLA.

@edgarmueller
Copy link
Contributor

@Lily418 Something went wrong here. Would you like to update once more?

@Lily418
Copy link
Contributor Author

Lily418 commented Jul 2, 2019

Hi Edgar, I switched laptops and didn't update my email for commits yet. Going to update this PR with suggestions and re-write the email on the commits.

@edgarmueller
Copy link
Contributor

Great, thank you!

@Lily418
Copy link
Contributor Author

Lily418 commented Jul 2, 2019

@edgarmueller updated 🚡

@edgarmueller
Copy link
Contributor

It's still complaining about the formatting, but other than that this looks good

Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edgarmueller edgarmueller removed the request for review from eneufeld July 3, 2019 08:01
@edgarmueller edgarmueller merged commit 523160e into eclipsesource:master Jul 3, 2019
@edgarmueller edgarmueller added this to the 2.3.0 milestone Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants