Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix dev container #2170

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Update and fix dev container #2170

merged 1 commit into from
Aug 21, 2023

Conversation

lucas-koehler
Copy link
Contributor

  • Update base image to version 1.x
  • Install chromium to enable running angular-material tests in the container
  • Extend README with hint to clean repo in case initialization fails

Fix #2149

- Update base image to version 1.x
- Install chromium to enable running angular-material tests in the container
- Extend README with hint to clean repo in case initialization fails

Fix #2149
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 56cbe5f
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64d62702b56e3f000808367d
😎 Deploy Preview https://deploy-preview-2170--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Aug 11, 2023

Coverage Status

coverage: 84.469%. remained the same when pulling 56cbe5f on 2149-dev-container into e685ae8 on master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@sdirix sdirix merged commit c1686c1 into master Aug 21, 2023
10 checks passed
@sdirix sdirix deleted the 2149-dev-container branch August 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev container: Fresh dev container fails to install dependencies
3 participants