-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update peer dependency for mui/icons in material-renderers #2186
update peer dependency for mui/icons in material-renderers #2186
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution ❤️
I added a comment inline. Please have a look.
@@ -87,7 +87,7 @@ | |||
"@emotion/styled": "^11.3.0", | |||
"@jsonforms/core": "3.1.1-alpha.0", | |||
"@jsonforms/react": "3.1.1-alpha.0", | |||
"@mui/icons-material": "~5.11.16", | |||
"@mui/icons-material": ">=5.11.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>=
seems a bit too lax to me because it also allows all higher major versions (e.g. 6.x, 7.x). I think we should change it to ^5.11.16
to allow all 5.x
versions but no other major versions. If it's known to work with 6.x it could then be adapted to ^5.11.16 || ^6.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's done :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IhsenBen ,
I changed it to ^5.11.16
because v6 does not exist yet and we don't know whether it will be compatible. Thanks for the issue and the PR :)
no problem, thx for your reactivity. |
@IhsenBen could you sign the contributor license agreement please? Otherwise I cannot merge this. You won't need to do this again in case you open further PRs in the future :) |
done |
self explanatory minor change