Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Disable schema caching in AJV instance #2201

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

LukasBoll
Copy link
Contributor

Set the 'addUsedSchema' option to false during AJV instantiation to prevent schema caching by default. This resolves issues where updating a schema that contains an ID leads to duplicate ID errors in AJV.

Closes #2071

Set the 'addUsedSchema' option to false during AJV instantiation to
prevent schema caching by default. This resolves issues where updating
a schema that contains an ID leads to duplicate ID errors in AJV.

Closes eclipsesource#2071
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit c62a29a
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/653ba2053cdbf900087c10ac
😎 Deploy Preview https://deploy-preview-2201--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 84.469%. remained the same when pulling c62a29a on LukasBoll:stateless_ajv into f905c82 on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 5602557 into eclipsesource:master Nov 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema with key or id "<url>" already exists
3 participants