-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Angular Datepicker #2281
Fix Angular Datepicker #2281
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3471299
to
4faf843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug seems to be fixed! However I encountered another issue during testing:
It's not possible for me to enter a "schemaBased" date via the keyboard into the textual input. The date always clears.
That's the first input of the "Dates" example
3237b92
to
d9f78ae
Compare
@LukasBoll Can you resolve the conflicts? |
replace toISOString(), which formats dates based on the UTC time zone with Angular DatePipe, which works with local time zones
Use a custom dateFormatter to enable the date picker format option. Enable the JSON Forms view options.
d9f78ae
to
a7bfafa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request addresses the "Angular date picker: selected date is off by one day" #2033 issue.
Starting from this implementation, I added the option to provide date formats and views in the uischema.