Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Angular Datepicker #2281

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

LukasBoll
Copy link
Contributor

This pull request addresses the "Angular date picker: selected date is off by one day" #2033 issue.
Starting from this implementation, I added the option to provide date formats and views in the uischema.

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit a7bfafa
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65ef5f770536430008bc7f06
😎 Deploy Preview https://deploy-preview-2281--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LukasBoll LukasBoll force-pushed the fix/angular-datepicker branch 2 times, most recently from 3471299 to 4faf843 Compare February 13, 2024 02:36
@coveralls
Copy link

coveralls commented Feb 13, 2024

Coverage Status

coverage: 84.822% (-0.06%) from 84.881%
when pulling a7bfafa on LukasBoll:fix/angular-datepicker
into 24f4e5f on eclipsesource:master.

@sdirix sdirix self-requested a review February 14, 2024 10:07
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug seems to be fixed! However I encountered another issue during testing:

It's not possible for me to enter a "schemaBased" date via the keyboard into the textual input. The date always clears.

That's the first input of the "Dates" example

packages/angular-material/tsconfig.json Outdated Show resolved Hide resolved
@LukasBoll LukasBoll force-pushed the fix/angular-datepicker branch 6 times, most recently from 3237b92 to d9f78ae Compare March 4, 2024 12:56
@LukasBoll LukasBoll requested a review from sdirix March 5, 2024 16:39
@sdirix
Copy link
Member

sdirix commented Mar 11, 2024

@LukasBoll Can you resolve the conflicts?

TheMicDiet and others added 4 commits March 11, 2024 20:32
replace toISOString(), which formats dates based on the UTC time zone with Angular DatePipe, which works with local time zones
Use a custom dateFormatter to enable the date picker format option.
Enable the JSON Forms view options.
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit 424484d into eclipsesource:master Mar 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants