Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed renderer to use StyleRegistry #603

Merged
merged 4 commits into from
Aug 1, 2017

Conversation

eneufeld
Copy link
Member

Fixes #577 for the vanilla case
Fixed an issue with the example switch

@eneufeld eneufeld force-pushed the fix_577 branch 2 times, most recently from 47cc7d1 to ebc4c16 Compare July 26, 2017 21:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.935% when pulling ebc4c16 on eneufeld:fix_577 into 45b62ff on eclipsesource:jsonforms2.

edgarmueller
edgarmueller previously approved these changes Aug 1, 2017
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods, typo only.

@@ -46,7 +58,7 @@ test('NumberControlTester', t => {
t.is(numberControlTester({type: 'Control'}, undefined), -1);
});

test('NumberControl tester with wrong schema type', t => {
test('NumberCostyleNamentrol tester with wrong schema type', t => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.296% when pulling 85c7083 on eneufeld:fix_577 into 6e919c7 on eclipsesource:jsonforms2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.296% when pulling 85089dd on eneufeld:fix_577 into 205e778 on eclipsesource:jsonforms2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.113% when pulling 8ac9f76 on eneufeld:fix_577 into 8d48f33 on eclipsesource:jsonforms2.

@edgarmueller edgarmueller merged commit c5a513f into eclipsesource:jsonforms2 Aug 1, 2017
@eneufeld eneufeld deleted the fix_577 branch December 7, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants